public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Reiter <s.reiter@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server] vzdump: improve error logging for query-proxmox-support
Date: Wed, 17 Mar 2021 11:19:35 +0100	[thread overview]
Message-ID: <20210317101935.5112-1-s.reiter@proxmox.com> (raw)

Only show "not supported by QEMU version" message if we determine that
to be the actual cause, just print the error otherwise.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
---
 PVE/VZDump/QemuServer.pm | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm
index 5a9ffab..4d171d2 100644
--- a/PVE/VZDump/QemuServer.pm
+++ b/PVE/VZDump/QemuServer.pm
@@ -490,9 +490,15 @@ sub archive_pbs {
 	};
 
 	my $qemu_support = eval { mon_cmd($vmid, "query-proxmox-support") };
-	if (!$qemu_support) {
-	    die "PBS backups are not supported by the running QEMU version. Please make "
-	      . "sure you've installed the latest version and the VM has been restarted.\n";
+	my $err = $@;
+	if (!$qemu_support || $err) {
+	    die "query-proxmox-support returned empty value\n" if !$err;
+	    if ($err =~ m/The command query-proxmox-support has not been found/) {
+		die "PBS backups are not supported by the running QEMU version. Please make "
+		  . "sure you've installed the latest version and the VM has been restarted.\n";
+	    } else {
+		die "QMP command query-proxmox-support failed - $err\n";
+	    }
 	}
 
 	my $fs_frozen = $self->qga_fs_freeze($task, $vmid);
-- 
2.20.1





             reply	other threads:[~2021-03-17 10:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-17 10:19 Stefan Reiter [this message]
2021-03-24  5:54 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210317101935.5112-1-s.reiter@proxmox.com \
    --to=s.reiter@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal