public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH storage 2/2] tests: zfs: complain when a first sub-test dies
Date: Fri, 12 Mar 2021 10:50:27 +0100	[thread overview]
Message-ID: <20210312095027.19451-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20210312095027.19451-1-f.ebner@proxmox.com>

Previously, $count was not increased and no test failure was reported.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---

Found by messing up in the previous patch at first with:
    my $res = map { $_ => [] } keys %{$ids};
instead of
    my $res = { map { $_ => [] } keys %{$ids} };
and wondering why it failed in "production", but the test ran through.

 test/run_test_zfspoolplugin.pl | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/test/run_test_zfspoolplugin.pl b/test/run_test_zfspoolplugin.pl
index 9c5e841..2f63f1b 100755
--- a/test/run_test_zfspoolplugin.pl
+++ b/test/run_test_zfspoolplugin.pl
@@ -2714,7 +2714,10 @@ for (my $i = $start_test; $i <= $end_test; $i++) {
     eval {
 	$tests->{$i}();
     };
-    warn $@ if $@;
+    if (my $err = $@) {
+	warn $err;
+	$count++;
+    }
     cleanup_zfs();
 }
 
-- 
2.20.1





  reply	other threads:[~2021-03-12  9:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-12  9:50 [pve-devel] [PATCH storage 1/2] vdisk list: only collect images from storages with an appropriate content type Fabian Ebner
2021-03-12  9:50 ` Fabian Ebner [this message]
2021-03-15 12:57   ` [pve-devel] applied: [PATCH storage 2/2] tests: zfs: complain when a first sub-test dies Thomas Lamprecht
2021-03-15 12:34 ` [pve-devel] [PATCH storage 1/2] vdisk list: only collect images from storages with an appropriate content type Thomas Lamprecht
2021-03-15 12:57 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210312095027.19451-2-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal