* [pve-devel] [PATCH qemu-server] vzdump: increase PBS 'backup' QMP call timeout
@ 2021-03-08 15:32 Stefan Reiter
2021-03-08 16:10 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Reiter @ 2021-03-08 15:32 UTC (permalink / raw)
To: pve-devel
Commit "a941bbd0 client: raise HTTP_TIMEOUT to 120s" in proxmox-backup
did the same, however, we would now still fail after 60 seconds since
the QMP call would time out.
Increase the timeout here to the same +5 seconds to give some time to
receive a response, so if the HTTP call in proxmox-backup times out, we
can still get a useful error message instead of timing out the QMP call
too.
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
---
Looked into it because of this forum thread:
https://forum.proxmox.com/threads/proxmox-backup-got-timeout.85465/
...though I'm pretty sure something else is amiss there.
PVE/VZDump/QemuServer.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm
index 901b366..5a9ffab 100644
--- a/PVE/VZDump/QemuServer.pm
+++ b/PVE/VZDump/QemuServer.pm
@@ -521,7 +521,7 @@ sub archive_pbs {
$params->{'use-dirty-bitmap'} = JSON::true
if $qemu_support->{'pbs-dirty-bitmap'} && !$is_template;
- $params->{timeout} = 60; # give some time to connect to the backup server
+ $params->{timeout} = 125; # give some time to connect to the backup server
my $res = eval { mon_cmd($vmid, "backup", %$params) };
my $qmperr = $@;
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH qemu-server] vzdump: increase PBS 'backup' QMP call timeout
2021-03-08 15:32 [pve-devel] [PATCH qemu-server] vzdump: increase PBS 'backup' QMP call timeout Stefan Reiter
@ 2021-03-08 16:10 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-03-08 16:10 UTC (permalink / raw)
To: Proxmox VE development discussion, Stefan Reiter
On 08.03.21 16:32, Stefan Reiter wrote:
> Commit "a941bbd0 client: raise HTTP_TIMEOUT to 120s" in proxmox-backup
> did the same, however, we would now still fail after 60 seconds since
> the QMP call would time out.
>
> Increase the timeout here to the same +5 seconds to give some time to
> receive a response, so if the HTTP call in proxmox-backup times out, we
> can still get a useful error message instead of timing out the QMP call
> too.
>
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
>
> Looked into it because of this forum thread:
> https://forum.proxmox.com/threads/proxmox-backup-got-timeout.85465/
> ...though I'm pretty sure something else is amiss there.
>
> PVE/VZDump/QemuServer.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-08 16:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-08 15:32 [pve-devel] [PATCH qemu-server] vzdump: increase PBS 'backup' QMP call timeout Stefan Reiter
2021-03-08 16:10 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox