public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH container 4/4] config: parse: also allow empty values
Date: Wed,  3 Mar 2021 12:01:28 +0100	[thread overview]
Message-ID: <20210303110128.9244-5-f.ebner@proxmox.com> (raw)
In-Reply-To: <20210303110128.9244-1-f.ebner@proxmox.com>

because they are valid for '-list' formats and it makes the behavior match with
what we do for VM configs. The new pattern is the same that is used for VM
configs. Because it is a non-greedy pattern, trailing whitespaces will not be
included in the value anymore. This /should/ cause no problems and the '\s*$'
at the end suggests that that is how it was intended in the first place.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
 src/PVE/LXC/Config.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index 5d223b2..de7e924 100644
--- a/src/PVE/LXC/Config.pm
+++ b/src/PVE/LXC/Config.pm
@@ -933,7 +933,7 @@ sub parse_pct_config {
 	    } else {
 		warn "vm $vmid - property 'delete' is only allowed in [pve:pending]\n";
 	    }
-	} elsif ($line =~ m/^([a-z][a-z_]*\d*):\s*(\S.*)\s*$/) {
+	} elsif ($line =~ m/^([a-z][a-z_]*\d*):\s*(.+?)\s*$/) {
 	    my $key = $1;
 	    my $value = $2;
 	    eval { $value = PVE::LXC::Config->check_type($key, $value); };
-- 
2.20.1





      parent reply	other threads:[~2021-03-03 11:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03 11:01 [pve-devel] [PATCH-SERIES] small improvements for parsing and printing Fabian Ebner
2021-03-03 11:01 ` [pve-devel] [PATCH qemu-server 1/4] vmstatus: make boolean value explicit Fabian Ebner
2021-03-03 16:53   ` Thomas Lamprecht
2021-03-04  8:04     ` Fabian Ebner
2021-03-04  8:59       ` Fabian Ebner
2021-03-03 11:01 ` [pve-devel] [PATCH qemu-server 2/4] config: parse: also warn about invalid lines Fabian Ebner
2021-03-03 16:51   ` [pve-devel] applied: " Thomas Lamprecht
2021-03-03 11:01 ` [pve-devel] [PATCH container 3/4] vmstatus: make boolean value explicit Fabian Ebner
2021-03-03 16:53   ` Thomas Lamprecht
2021-03-03 11:01 ` Fabian Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210303110128.9244-5-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal