From: Oguz Bektas <o.bektas@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH storage] fix #3203: report smart status correctly
Date: Tue, 2 Mar 2021 13:33:55 +0100 [thread overview]
Message-ID: <20210302123355.GA11423@gaia.proxmox.com> (raw)
In-Reply-To: <00a8dc69-5e30-9a95-552e-d374656709ac@proxmox.com>
hi,
On Tue, Mar 02, 2021 at 09:34:41AM +0100, Dominik Csapak wrote:
> On 3/1/21 14:56, Oguz Bektas wrote:
> > if the -a option isn't passed, -H might report a failing disk as
> > 'PASSED' even when the disk might be in a corrupted state.
> >
> > Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> > ---
> > PVE/Diskmanage.pm | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/PVE/Diskmanage.pm b/PVE/Diskmanage.pm
> > index 64bb813..d3c3365 100644
> > --- a/PVE/Diskmanage.pm
> > +++ b/PVE/Diskmanage.pm
> > @@ -95,8 +95,9 @@ sub get_smart_data {
> > or die "failed to get nvme controller device for $disk\n");
> > }
> > - my $cmd = [$SMARTCTL, '-H'];
> > - push @$cmd, '-A', '-f', 'brief' if !$healthonly;
> > + my $cmd = [$SMARTCTL];
> > + push @$cmd, '-H' if $healthonly;
> > + push @$cmd, '-a', '-A', '-f', 'brief' if !$healthonly;
> > push @$cmd, $disk;
> > eval {
> >
>
> after looking at our code, this patch does not solve the issue the
> user in #3203 has
>
> we purposely ignore the return value of smartctl except
> for sever smartctl errors (such as device open failed or faulty command
> line) and parse the status from the text itself
>
> but the text (PASSED) does not change regardless if -H is given or not
>
> the real fix for the issue is to start parsing the smart errors separately
> and show them to the user somehow
hmm yeah you're right, thanks!
>
> while doing this, we should change our parser to use the '--json' flag
> of smartcl
i will take a look. like you also mentioned off-list we do this in
backup server code with the json flag, so it makes sense to do it here
as well
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
prev parent reply other threads:[~2021-03-02 12:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 13:56 Oguz Bektas
2021-03-01 16:40 ` Dietmar Maurer
2021-03-02 8:34 ` Dominik Csapak
2021-03-02 12:33 ` Oguz Bektas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210302123355.GA11423@gaia.proxmox.com \
--to=o.bektas@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox