* [pve-devel] [PATCH qemu-server 1/2] schema: mention special syntax for allocating a new volume
@ 2021-03-02 12:02 Fabian Ebner
2021-03-02 12:02 ` [pve-devel] [PATCH container 2/2] " Fabian Ebner
2021-03-30 16:37 ` [pve-devel] applied: [PATCH qemu-server 1/2] " Thomas Lamprecht
0 siblings, 2 replies; 4+ messages in thread
From: Fabian Ebner @ 2021-03-02 12:02 UTC (permalink / raw)
To: pve-devel
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
PVE/QemuServer/Drive.pm | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/PVE/QemuServer/Drive.pm b/PVE/QemuServer/Drive.pm
index d560937..01ea8d7 100644
--- a/PVE/QemuServer/Drive.pm
+++ b/PVE/QemuServer/Drive.pm
@@ -253,10 +253,14 @@ my $ide_fmt = {
};
PVE::JSONSchema::register_format("pve-qm-ide", $ide_fmt);
+my $ALLOCATION_SYNTAX_DESC =
+ "Use the special syntax STORAGE_ID:SIZE_IN_GiB to allocate a new volume.";
+
my $idedesc = {
optional => 1,
type => 'string', format => $ide_fmt,
- description => "Use volume as IDE hard disk or CD-ROM (n is 0 to " .($MAX_IDE_DISKS -1) . ").",
+ description => "Use volume as IDE hard disk or CD-ROM (n is 0 to " .($MAX_IDE_DISKS -1) . "). " .
+ $ALLOCATION_SYNTAX_DESC,
};
PVE::JSONSchema::register_standard_option("pve-qm-ide", $idedesc);
@@ -271,7 +275,8 @@ my $scsi_fmt = {
my $scsidesc = {
optional => 1,
type => 'string', format => $scsi_fmt,
- description => "Use volume as SCSI hard disk or CD-ROM (n is 0 to " . ($MAX_SCSI_DISKS - 1) . ").",
+ description => "Use volume as SCSI hard disk or CD-ROM (n is 0 to " . ($MAX_SCSI_DISKS - 1) . "). " .
+ $ALLOCATION_SYNTAX_DESC,
};
PVE::JSONSchema::register_standard_option("pve-qm-scsi", $scsidesc);
@@ -283,7 +288,8 @@ my $sata_fmt = {
my $satadesc = {
optional => 1,
type => 'string', format => $sata_fmt,
- description => "Use volume as SATA hard disk or CD-ROM (n is 0 to " . ($MAX_SATA_DISKS - 1). ").",
+ description => "Use volume as SATA hard disk or CD-ROM (n is 0 to " . ($MAX_SATA_DISKS - 1). "). " .
+ $ALLOCATION_SYNTAX_DESC,
};
PVE::JSONSchema::register_standard_option("pve-qm-sata", $satadesc);
@@ -294,7 +300,8 @@ my $virtio_fmt = {
my $virtiodesc = {
optional => 1,
type => 'string', format => $virtio_fmt,
- description => "Use volume as VIRTIO hard disk (n is 0 to " . ($MAX_VIRTIO_DISKS - 1) . ").",
+ description => "Use volume as VIRTIO hard disk (n is 0 to " . ($MAX_VIRTIO_DISKS - 1) . "). " .
+ $ALLOCATION_SYNTAX_DESC,
};
PVE::JSONSchema::register_standard_option("pve-qm-virtio", $virtiodesc);
@@ -330,7 +337,9 @@ my $efidisk_fmt = {
my $efidisk_desc = {
optional => 1,
type => 'string', format => $efidisk_fmt,
- description => "Configure a Disk for storing EFI vars",
+ description => "Configure a Disk for storing EFI vars. " .
+ $ALLOCATION_SYNTAX_DESC . " Note that SIZE_IN_GiB is ignored here " .
+ "and that the default EFI vars are copied to the volume instead.",
};
PVE::JSONSchema::register_standard_option("pve-qm-efidisk", $efidisk_desc);
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pve-devel] [PATCH container 2/2] schema: mention special syntax for allocating a new volume
2021-03-02 12:02 [pve-devel] [PATCH qemu-server 1/2] schema: mention special syntax for allocating a new volume Fabian Ebner
@ 2021-03-02 12:02 ` Fabian Ebner
2021-04-18 16:18 ` [pve-devel] applied: " Thomas Lamprecht
2021-03-30 16:37 ` [pve-devel] applied: [PATCH qemu-server 1/2] " Thomas Lamprecht
1 sibling, 1 reply; 4+ messages in thread
From: Fabian Ebner @ 2021-03-02 12:02 UTC (permalink / raw)
To: pve-devel
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
src/PVE/LXC/Config.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index 5d223b2..f74ca9d 100644
--- a/src/PVE/LXC/Config.pm
+++ b/src/PVE/LXC/Config.pm
@@ -855,7 +855,8 @@ for (my $i = 0; $i < $MAX_MOUNT_POINTS; $i++) {
$confdesc->{"mp$i"} = {
optional => 1,
type => 'string', format => $mp_desc,
- description => "Use volume as container mount point.",
+ description => "Use volume as container mount point. Use the special " .
+ "syntax STORAGE_ID:SIZE_IN_GiB to allocate a new volume.",
optional => 1,
};
}
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pve-devel] applied: [PATCH qemu-server 1/2] schema: mention special syntax for allocating a new volume
2021-03-02 12:02 [pve-devel] [PATCH qemu-server 1/2] schema: mention special syntax for allocating a new volume Fabian Ebner
2021-03-02 12:02 ` [pve-devel] [PATCH container 2/2] " Fabian Ebner
@ 2021-03-30 16:37 ` Thomas Lamprecht
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2021-03-30 16:37 UTC (permalink / raw)
To: Proxmox VE development discussion, Fabian Ebner
On 02.03.21 13:02, Fabian Ebner wrote:
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> PVE/QemuServer/Drive.pm | 19 ++++++++++++++-----
> 1 file changed, 14 insertions(+), 5 deletions(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pve-devel] applied: [PATCH container 2/2] schema: mention special syntax for allocating a new volume
2021-03-02 12:02 ` [pve-devel] [PATCH container 2/2] " Fabian Ebner
@ 2021-04-18 16:18 ` Thomas Lamprecht
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2021-04-18 16:18 UTC (permalink / raw)
To: Proxmox VE development discussion, Fabian Ebner
On 02.03.21 13:02, Fabian Ebner wrote:
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> src/PVE/LXC/Config.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-18 16:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-02 12:02 [pve-devel] [PATCH qemu-server 1/2] schema: mention special syntax for allocating a new volume Fabian Ebner
2021-03-02 12:02 ` [pve-devel] [PATCH container 2/2] " Fabian Ebner
2021-04-18 16:18 ` [pve-devel] applied: " Thomas Lamprecht
2021-03-30 16:37 ` [pve-devel] applied: [PATCH qemu-server 1/2] " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox