public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH storage 1/1] disks: zfs: scan is only returned optionally
Date: Thu, 25 Feb 2021 22:23:04 +0100	[thread overview]
Message-ID: <20210225212305.17954-2-s.ivanov@proxmox.com> (raw)
In-Reply-To: <20210225212305.17954-1-s.ivanov@proxmox.com>

the line is not present if a zpool has never been scrubbed before
(e.g. if it's freshly setup)

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 PVE/API2/Disks/ZFS.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/PVE/API2/Disks/ZFS.pm b/PVE/API2/Disks/ZFS.pm
index 2884bb0..b815ee7 100644
--- a/PVE/API2/Disks/ZFS.pm
+++ b/PVE/API2/Disks/ZFS.pm
@@ -163,6 +163,7 @@ __PACKAGE__->register_method ({
 		description => 'Information about the recommended action to fix the state.',
 	    },
 	    scan => {
+		optional => 1,
 		type => 'string',
 		description => 'Information about the last/current scrub.',
 	    },
-- 
2.20.1





  reply	other threads:[~2021-02-25 21:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25 21:23 [pve-devel] [PATCH storage/manager] fix cosmetic api issue with zpool status output Stoiko Ivanov
2021-02-25 21:23 ` Stoiko Ivanov [this message]
2021-02-26  8:10   ` [pve-devel] applied: [PATCH storage 1/1] disks: zfs: scan is only returned optionally Thomas Lamprecht
2021-02-25 21:23 ` [pve-devel] [PATCH manager 1/1] ui: zpool status detail: add default for scrub information Stoiko Ivanov
2021-02-26  8:17   ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210225212305.17954-2-s.ivanov@proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal