From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 manager 3/4] ui: qemu/HardwareView: eslint: enforce "no-shadow" rule
Date: Fri, 12 Feb 2021 16:57:49 +0100 [thread overview]
Message-ID: <20210212155751.16045-3-a.lauterer@proxmox.com> (raw)
In-Reply-To: <20210212155751.16045-1-a.lauterer@proxmox.com>
By removing global vars 'i' and 'confid' and declaring them with let in the needed
context.
'i' wasn't necessary but had to be touched anyway.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
v2: removed the global definitions for i and confid and declared them
locally where needed.
www/manager6/qemu/HardwareView.js | 25 ++++++++++++-------------
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js
index 730a44d9..036bfa26 100644
--- a/www/manager6/qemu/HardwareView.js
+++ b/www/manager6/qemu/HardwareView.js
@@ -45,7 +45,6 @@ Ext.define('PVE.qemu.HardwareView', {
initComponent: function() {
var me = this;
- var i, confid;
var nodename = me.pveSelNode.data.node;
if (!nodename) {
@@ -220,7 +219,7 @@ Ext.define('PVE.qemu.HardwareView', {
};
PVE.Utils.forEachBus(undefined, function(type, id) {
- var confid = type + id;
+ let confid = type + id;
rows[confid] = {
group: 10,
iconCls: 'hdd-o',
@@ -232,8 +231,8 @@ Ext.define('PVE.qemu.HardwareView', {
cloudheader: gettext('CloudInit Drive') + ' (' + confid + ')',
};
});
- for (i = 0; i < PVE.Utils.hardware_counts.net; i++) {
- confid = "net" + i.toString();
+ for (let i = 0; i < PVE.Utils.hardware_counts.net; i++) {
+ let confid = "net" + i.toString();
rows[confid] = {
group: 15,
order: i,
@@ -250,8 +249,8 @@ Ext.define('PVE.qemu.HardwareView', {
never_delete: !caps.vms['VM.Config.Disk'],
header: gettext('EFI Disk'),
};
- for (i = 0; i < PVE.Utils.hardware_counts.usb; i++) {
- confid = "usb" + i.toString();
+ for (let i = 0; i < PVE.Utils.hardware_counts.usb; i++) {
+ let confid = "usb" + i.toString();
rows[confid] = {
group: 25,
order: i,
@@ -261,8 +260,8 @@ Ext.define('PVE.qemu.HardwareView', {
header: gettext('USB Device') + ' (' + confid + ')',
};
}
- for (i = 0; i < PVE.Utils.hardware_counts.hostpci; i++) {
- confid = "hostpci" + i.toString();
+ for (let i = 0; i < PVE.Utils.hardware_counts.hostpci; i++) {
+ let confid = "hostpci" + i.toString();
rows[confid] = {
group: 30,
order: i,
@@ -272,8 +271,8 @@ Ext.define('PVE.qemu.HardwareView', {
header: gettext('PCI Device') + ' (' + confid + ')',
};
}
- for (i = 0; i < PVE.Utils.hardware_counts.serial; i++) {
- confid = "serial" + i.toString();
+ for (let i = 0; i < PVE.Utils.hardware_counts.serial; i++) {
+ let confid = "serial" + i.toString();
rows[confid] = {
group: 35,
order: i,
@@ -289,7 +288,7 @@ Ext.define('PVE.qemu.HardwareView', {
never_delete: !caps.vms['VM.Config.HWType'],
header: gettext('Audio Device'),
};
- for (i = 0; i < 256; i++) {
+ for (let i = 0; i < 256; i++) {
rows["unused" + i.toString()] = {
group: 99,
order: i,
@@ -531,8 +530,8 @@ Ext.define('PVE.qemu.HardwareView', {
let isAtLimit = (type) => counts[type] >= PVE.Utils.hardware_counts[type];
var set_button_status = function() {
- var sm = me.getSelectionModel();
- var rec = sm.getSelection()[0];
+ var selection_model = me.getSelectionModel();
+ var rec = selection_model.getSelection()[0];
// en/disable hardwarebuttons
counts = {};
--
2.20.1
next prev parent reply other threads:[~2021-02-12 15:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 15:57 [pve-devel] [PATCH v2 manager 1/4] ui: qemu/HardwareView: eslint: enforce "max-len" rule Aaron Lauterer
2021-02-12 15:57 ` [pve-devel] [PATCH v2 manager 2/4] ui: qemu/HardwareView: eslint: enforce "no-useless-concat" rule Aaron Lauterer
2021-02-19 15:47 ` [pve-devel] applied: " Thomas Lamprecht
2021-02-12 15:57 ` Aaron Lauterer [this message]
2021-02-19 15:47 ` [pve-devel] applied: [PATCH v2 manager 3/4] ui: qemu/HardwareView: eslint: enforce "no-shadow" rule Thomas Lamprecht
2021-02-12 15:57 ` [pve-devel] [PATCH v2 qemu-server] API: update_vm_api: check for CDROM on disk delete Aaron Lauterer
2021-02-22 16:40 ` [pve-devel] applied: " Thomas Lamprecht
2021-02-12 15:57 ` [pve-devel] [PATCH v2 manager 4/4] ui: qemu/HardwareView: fix CDRom permission checkss Aaron Lauterer
2021-02-19 16:32 ` [pve-devel] applied: " Thomas Lamprecht
2021-02-19 15:46 ` [pve-devel] applied: [PATCH v2 manager 1/4] ui: qemu/HardwareView: eslint: enforce "max-len" rule Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210212155751.16045-3-a.lauterer@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox