public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH storage] NFS: avoid using obsolete rpcinfo option
Date: Thu,  4 Feb 2021 09:04:26 +0100	[thread overview]
Message-ID: <20210204080426.8221-1-f.ebner@proxmox.com> (raw)

as suggested in the man page.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
 PVE/Storage/NFSPlugin.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/Storage/NFSPlugin.pm b/PVE/Storage/NFSPlugin.pm
index 72e06c2..cb16864 100644
--- a/PVE/Storage/NFSPlugin.pm
+++ b/PVE/Storage/NFSPlugin.pm
@@ -166,7 +166,7 @@ sub check_connection {
     if (defined($opts) && $opts =~ /vers=4.*/) {
 	# nfsv4 uses a pseudo-filesystem always beginning with /
 	# no exports are listed
-	$cmd = ['/usr/sbin/rpcinfo', '-t', $server, 'nfs', '4'];
+	$cmd = ['/usr/sbin/rpcinfo', '-T', 'tcp', $server, 'nfs', '4'];
     } else {
 	$cmd = ['/sbin/showmount', '--no-headers', '--exports', $server];
     }
-- 
2.20.1





             reply	other threads:[~2021-02-04  8:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04  8:04 Fabian Ebner [this message]
2021-02-19 14:29 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210204080426.8221-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal