From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH-SERIES] partially fix #2285: extend Diskmanage to also list partitions
Date: Tue, 26 Jan 2021 12:45:16 +0100 [thread overview]
Message-ID: <20210126114530.8753-1-f.ebner@proxmox.com> (raw)
and fix some other little things along the way (see patches #1, #4, #9).
Mostly re-uses existing functionality, but refactors it, so it can be re-used
for partitions as well. New is the detection of filesystems via lsblk and the
detection of more PVE-relevant partuuids.
In the UI, the current list is replaced by a treepanel including the partitions.
This series does not yet make it possible to select partitons for storage
creation for certain types, which is one of the parts of bug #2285. I felt
like this series was getting rather big already and that there was more
discussion to be had about that and it can always be done as a follow-up series.
The usage of a partition currently always defaults to 'partition'. A good
heuristic to find out when a partition is unused would be needed and/or good
ways to warn the user and ask if they're sure they have the correct partition.
This also ties in to the proposed feature of allowing users to wipe disks under
certain conditions.
storage:
Fabian Ebner (11):
Disks: return correct journal disk candidates
Diskmanage: replace closure with direct hash access
Diskmanage: refactor and rename get_parttype_info
Diskmanage: also check for filesystem type when determining usage
Diskmanage: introduce get_sysdir_size helper
Diskmanage: collect partitions in hash
Diskmanage: introduce usage helper
Diskmanage: also detect BIOS boot, EFI and ZFS reserved type
partitions
Diskmanage: introduce ceph info helper
Diskmanage: save OSD information for individual partitions
Diskmanage: also include partitions with get_disks if flag is set
PVE/API2/Disks.pm | 24 +-
PVE/Diskmanage.pm | 207 +++++++++++-------
test/disk_tests/usages/disklist | 1 +
test/disk_tests/usages/disklist_expected.json | 15 ++
test/disk_tests/usages/lsblk | 7 +-
test/disk_tests/usages/sdd/sdd1/size | 1 +
test/disk_tests/usages/sdd/sdd2/size | 1 +
test/disk_tests/usages/sde/sde1/size | 1 +
test/disk_tests/usages/sdf/sdf1/size | 1 +
test/disk_tests/usages/sdm/sdm1/size | 1 +
test/disk_tests/usages/sdm/sdm9/size | 1 +
test/disk_tests/usages/sdn/device/vendor | 1 +
test/disk_tests/usages/sdn/queue/rotational | 1 +
test/disk_tests/usages/sdn/size | 1 +
test/disk_tests/usages/sdn_udevadm | 14 ++
test/disklist_test.pm | 12 +
16 files changed, 207 insertions(+), 82 deletions(-)
create mode 100644 test/disk_tests/usages/sdd/sdd1/size
create mode 100644 test/disk_tests/usages/sdd/sdd2/size
create mode 100644 test/disk_tests/usages/sde/sde1/size
create mode 100644 test/disk_tests/usages/sdf/sdf1/size
create mode 100644 test/disk_tests/usages/sdm/sdm1/size
create mode 100644 test/disk_tests/usages/sdm/sdm9/size
create mode 100644 test/disk_tests/usages/sdn/device/vendor
create mode 100644 test/disk_tests/usages/sdn/queue/rotational
create mode 100644 test/disk_tests/usages/sdn/size
create mode 100644 test/disk_tests/usages/sdn_udevadm
manager:
Fabian Ebner (1):
api: Ceph: add reminder to remove 'disks' call
PVE/API2/Ceph.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
widget-toolkit:
Fabian Ebner (2):
convert disk list to disk tree including the partitions
move DiskList.js from grid/ to panel/
src/Makefile | 2 +-
src/{grid => panel}/DiskList.js | 97 ++++++++++++++++++++++++++-------
2 files changed, 79 insertions(+), 20 deletions(-)
rename src/{grid => panel}/DiskList.js (72%)
--
2.20.1
next reply other threads:[~2021-01-26 11:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 11:45 Fabian Ebner [this message]
2021-01-26 11:45 ` [pve-devel] [PATCH storage 01/14] Disks: return correct journal disk candidates Fabian Ebner
2021-01-26 11:45 ` [pve-devel] [PATCH storage 02/14] Diskmanage: replace closure with direct hash access Fabian Ebner
2021-01-26 11:45 ` [pve-devel] [PATCH storage 03/14] Diskmanage: refactor and rename get_parttype_info Fabian Ebner
2021-01-26 11:45 ` [pve-devel] [PATCH storage 04/14] Diskmanage: also check for filesystem type when determining usage Fabian Ebner
2021-01-26 11:45 ` [pve-devel] [PATCH storage 05/14] Diskmanage: introduce get_sysdir_size helper Fabian Ebner
2021-01-26 11:45 ` [pve-devel] [PATCH storage 06/14] Diskmanage: collect partitions in hash Fabian Ebner
2021-01-26 11:45 ` [pve-devel] [PATCH storage 07/14] Diskmanage: introduce usage helper Fabian Ebner
2021-01-26 11:45 ` [pve-devel] [PATCH storage 08/14] Diskmanage: also detect BIOS boot, EFI and ZFS reserved type partitions Fabian Ebner
2021-01-26 11:45 ` [pve-devel] [PATCH storage 09/14] Diskmanage: introduce ceph info helper Fabian Ebner
2021-01-26 11:45 ` [pve-devel] [PATCH storage 10/14] Diskmanage: save OSD information for individual partitions Fabian Ebner
2021-01-26 11:45 ` [pve-devel] [PATCH storage 11/14] Diskmanage: also include partitions with get_disks if flag is set Fabian Ebner
2021-01-26 11:45 ` [pve-devel] [PATCH manager 12/14] api: Ceph: add reminder to remove 'disks' call Fabian Ebner
2021-01-26 11:45 ` [pve-devel] [PATCH widget-toolkit 13/14] convert disk list to disk tree including the partitions Fabian Ebner
2021-01-26 11:45 ` [pve-devel] [PATCH widget-toolkit 14/14] move DiskList.js from grid/ to panel/ Fabian Ebner
2021-02-06 13:13 ` [pve-devel] partially-applied: [PATCH-SERIES] partially fix #2285: extend Diskmanage to also list partitions Thomas Lamprecht
2021-02-08 7:58 ` Fabian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210126114530.8753-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox