From: Stephane CHAZELAS <stephane@chazelas.org>
To: Bruce Wainer <brwainer@gmail.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH] ZFS ARC size not taken into account by pvestatd or ksmtuned
Date: Sun, 24 Jan 2021 09:22:26 +0000 [thread overview]
Message-ID: <20210124092226.dghkhgmmkvffwyuc@chazelas.org> (raw)
In-Reply-To: <CAPEXuiyXfZHmeFsCzz1+rYQiqXukaQN8L8zshEXiDpM9YV6Gdw@mail.gmail.com>
2021-01-23 04:14:52 -0500, Bruce Wainer:
[...]
> Alternatively if you are not willing to go through the steps of submitting
> this yourself, we might be able to work things out so I can submit it.
[...]
Hi Bruce,
yes please. That's a very simple change. The idea is just to
count the ARC size as buffer/cache like the rest of the buffer/
cache. It doesn't really matter much how it's done exactly. I
use git rarely enough that it always me hours to get back into
it.
I see that ksmtuned is actually upstream at RedHat so I suppose
Proxmox will likely want to add the change as an extra debian
patch.
I think I should point out that I've not revisited that issue in
years. And at the time the aim was to quickly address the issue
for our specific use case. There may be better ways to address
it these days. In particular, I'm not sure why the kernel
doesn't account the ARC in buffers/cache in the first place,
maybe that's customisable now. I've not had a look at that
/proc/pressure thing referenced in the latest commit of
ProcFSTools either. But in any case, the patch I submitted has
proved to be an improvement for us.
Cheers,
Stephane
prev parent reply other threads:[~2021-01-24 9:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 14:42 Stephane Chazelas
2021-01-23 9:14 ` Bruce Wainer
2021-01-24 9:22 ` Stephane CHAZELAS [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210124092226.dghkhgmmkvffwyuc@chazelas.org \
--to=stephane@chazelas.org \
--cc=brwainer@gmail.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox