[pve-devel] [PATCH manager] vzdump: avoid parsing already parsed option

[pve-devel] [PATCH manager] vzdump: avoid parsing already parsed option

[Fabian Ebner]

When a job is updated, verify_vzdump_parameters() is called twice. This led to
parse_property_string being called with the already parsed option.

Reported on the pve-user mailing list:
https://lists.proxmox.com/pipermail/pve-user/2021-January/172258.html

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---

The following patch is also necessary, for the cron file read/write:
https://lists.proxmox.com/pipermail/pve-devel/2020-November/046101.html

 PVE/VZDump.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index d6f9709b..a99d0565 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -79,6 +79,7 @@ my $parse_prune_backups_maxfiles = sub {
         if defined($maxfiles) && defined($prune_backups);
 
     if (defined($prune_backups)) {
+	return if ref($prune_backups) eq 'HASH'; # already parsed
 	$param->{'prune-backups'} = PVE::JSONSchema::parse_property_string(
 	    'prune-backups',
 	    $prune_backups
-- 
2.20.1

[pve-devel] applied: [PATCH manager] vzdump: avoid parsing already parsed option

[Thomas Lamprecht]

On 15.01.21 13:49, Fabian Ebner wrote:
> When a job is updated, verify_vzdump_parameters() is called twice. This led to
> parse_property_string being called with the already parsed option.
> 
> Reported on the pve-user mailing list:
> https://lists.proxmox.com/pipermail/pve-user/2021-January/172258.html
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> 
> The following patch is also necessary, for the cron file read/write:
> https://lists.proxmox.com/pipermail/pve-devel/2020-November/046101.html
> 
>  PVE/VZDump.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied, thanks!