* [pve-devel] [PATCH manager] vzdump: avoid parsing already parsed option
@ 2021-01-15 12:49 Fabian Ebner
2021-01-26 17:48 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Ebner @ 2021-01-15 12:49 UTC (permalink / raw)
To: pve-devel
When a job is updated, verify_vzdump_parameters() is called twice. This led to
parse_property_string being called with the already parsed option.
Reported on the pve-user mailing list:
https://lists.proxmox.com/pipermail/pve-user/2021-January/172258.html
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
The following patch is also necessary, for the cron file read/write:
https://lists.proxmox.com/pipermail/pve-devel/2020-November/046101.html
PVE/VZDump.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index d6f9709b..a99d0565 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -79,6 +79,7 @@ my $parse_prune_backups_maxfiles = sub {
if defined($maxfiles) && defined($prune_backups);
if (defined($prune_backups)) {
+ return if ref($prune_backups) eq 'HASH'; # already parsed
$param->{'prune-backups'} = PVE::JSONSchema::parse_property_string(
'prune-backups',
$prune_backups
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager] vzdump: avoid parsing already parsed option
2021-01-15 12:49 [pve-devel] [PATCH manager] vzdump: avoid parsing already parsed option Fabian Ebner
@ 2021-01-26 17:48 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-01-26 17:48 UTC (permalink / raw)
To: Proxmox VE development discussion, Fabian Ebner
On 15.01.21 13:49, Fabian Ebner wrote:
> When a job is updated, verify_vzdump_parameters() is called twice. This led to
> parse_property_string being called with the already parsed option.
>
> Reported on the pve-user mailing list:
> https://lists.proxmox.com/pipermail/pve-user/2021-January/172258.html
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>
> The following patch is also necessary, for the cron file read/write:
> https://lists.proxmox.com/pipermail/pve-devel/2020-November/046101.html
>
> PVE/VZDump.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-26 17:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-15 12:49 [pve-devel] [PATCH manager] vzdump: avoid parsing already parsed option Fabian Ebner
2021-01-26 17:48 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox