* [pve-devel] [PATCH storage] lvm: Fix #3159: Show RAID LVs as storage content
@ 2021-01-13 12:19 Dominic Jäger
2021-01-26 18:20 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominic Jäger @ 2021-01-13 12:19 UTC (permalink / raw)
To: pve-devel
LVM RAID logical volumes (including mirrors) can be valid disk images, so they
should show up in storage content listings (for example pvesm list).
Including LV types is safer than excluding, especially because of possible
additional types in the future.
Co-developed-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
---
PVE/Storage/LVMPlugin.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/Storage/LVMPlugin.pm b/PVE/Storage/LVMPlugin.pm
index 73e8e48..df49b76 100644
--- a/PVE/Storage/LVMPlugin.pm
+++ b/PVE/Storage/LVMPlugin.pm
@@ -446,7 +446,8 @@ sub list_images {
next if $scfg->{tagged_only} && !&$check_tags($info->{tags});
- next if $info->{lv_type} ne '-';
+ # Allow mirrored and RAID LVs
+ next if $info->{lv_type} !~ m/^[-mMrR]$/;
my $volid = "$storeid:$volname";
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread* [pve-devel] applied: [PATCH storage] lvm: Fix #3159: Show RAID LVs as storage content
2021-01-13 12:19 [pve-devel] [PATCH storage] lvm: Fix #3159: Show RAID LVs as storage content Dominic Jäger
@ 2021-01-26 18:20 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-01-26 18:20 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominic Jäger
On 13.01.21 13:19, Dominic Jäger wrote:
> LVM RAID logical volumes (including mirrors) can be valid disk images, so they
> should show up in storage content listings (for example pvesm list).
>
> Including LV types is safer than excluding, especially because of possible
> additional types in the future.
>
> Co-developed-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
> ---
> PVE/Storage/LVMPlugin.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-26 18:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-13 12:19 [pve-devel] [PATCH storage] lvm: Fix #3159: Show RAID LVs as storage content Dominic Jäger
2021-01-26 18:20 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox