[pve-devel] [PATCH-SERIES] add none audio backend

[pve-devel] [PATCH-SERIES] add none audio backend

[Gilles Pietri]

Add the 'none' audio backend as an option for qemu-server: it behaves
the same as the spice one (id=,driver=), and simply discards audio.
Add the option in the Web UI for audio configuration.

[pve-devel] [PATCH qemu-server] audio: add the none audio backend

[Gilles Pietri]

Signed-off-by: Gilles Pietri <contact+dev@gilouweb.com>
---
 PVE/QemuServer.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index bca5669..54278e5 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -211,7 +211,7 @@ my $audio_fmt = {
     },
     driver =>  {
 	type => 'string',
-	enum => ['spice'],
+	enum => ['spice', 'none'],
 	default => 'spice',
 	optional => 1,
 	description => "Driver backend for the audio device."
-- 
2.30.0

[pve-devel] [PATCH pve-manager] ui: qemu: add the none audio driver as an option

[Gilles Pietri]

Signed-off-by: Gilles Pietri <contact+dev@gilouweb.com>
---
 www/manager6/qemu/AudioEdit.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/www/manager6/qemu/AudioEdit.js b/www/manager6/qemu/AudioEdit.js
index 804e5a7a..4d039adf 100644
--- a/www/manager6/qemu/AudioEdit.js
+++ b/www/manager6/qemu/AudioEdit.js
@@ -29,10 +29,14 @@ Ext.define('PVE.qemu.AudioInputPanel', {
 	]
     }, {
 	name: 'driver',
-	xtype: 'displayfield',
+	xtype: 'proxmoxKVComboBox',
 	value: 'spice',
 	submitValue: true,
 	fieldLabel: gettext('Backend Driver'),
+	comboItems: [
+	    ['spice', 'spice'],
+	    ['none', 'none'],
+	]
     }]
 });
 
-- 
2.30.0

Re: [pve-devel] [PATCH-SERIES] add none audio backend

[Aaron Lauterer]

The series looks good to me.

One thing we need to do is to adapt the documentation because right now it specifically mentions that the audio device only works in combination with Spice.

Reviewed-By: Aaron Lauterer <a.lauterer@proxmox.com>
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>

On 1/7/21 6:02 PM, Gilles Pietri wrote:
> Add the 'none' audio backend as an option for qemu-server: it behaves
> the same as the spice one (id=,driver=), and simply discards audio.
> Add the option in the Web UI for audio configuration.
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 

[pve-devel] applied-series: [PATCH-SERIES] add none audio backend

[Thomas Lamprecht]

On 07.01.21 18:02, Gilles Pietri wrote:
> Add the 'none' audio backend as an option for qemu-server: it behaves
> the same as the spice one (id=,driver=), and simply discards audio.
> Add the option in the Web UI for audio configuration.


applied series, much thanks for your contribution!