public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Dominic Jäger" <d.jaeger@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 1/2] ui: firewall: Clarify group rule subjects
Date: Tue,  5 Jan 2021 12:00:32 +0100	[thread overview]
Message-ID: <20210105110033.37620-1-d.jaeger@proxmox.com> (raw)

First, both buttons add a row to the grid, so they should be both "Add" (or both
"Insert").
Secondly, we add a (security group) rule to the grid, not the group itself.
Thirdly, the window title should be different to the regular rule.

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
---
 www/manager6/grid/FirewallRules.js | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/www/manager6/grid/FirewallRules.js b/www/manager6/grid/FirewallRules.js
index 42035129..08deee2a 100644
--- a/www/manager6/grid/FirewallRules.js
+++ b/www/manager6/grid/FirewallRules.js
@@ -361,7 +361,7 @@ Ext.define('PVE.FirewallGroupRuleEdit', {
 	});
 
 	Ext.apply(me, {
-            subject: gettext('Rule'),
+            subject: gettext('Group rule'),
 	    isAdd: true,
 	    items: [ ipanel ]
 	});
@@ -578,8 +578,7 @@ Ext.define('PVE.FirewallRules', {
 
 	if (me.allow_groups) {
 	    me.groupBtn =  Ext.create('Ext.Button', {
-		text: gettext('Insert') + ': ' + 
-		    gettext('Security Group'),
+		text: gettext('Add') + ': ' + gettext('Group rule'),
 		disabled: true,
 		handler: function() {
 		    var win = Ext.create('PVE.FirewallGroupRuleEdit', {
-- 
2.20.1




             reply	other threads:[~2021-01-05 11:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-05 11:00 Dominic Jäger [this message]
2021-01-05 11:00 ` [pve-devel] [PATCH manager 2/2] ui: firewall: Clarify text for "Add" button Dominic Jäger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210105110033.37620-1-d.jaeger@proxmox.com \
    --to=d.jaeger@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal