public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] ceph: extend error for wrong config-file link
@ 2020-12-16 11:46 Stoiko Ivanov
  2020-12-18 16:52 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Stoiko Ivanov @ 2020-12-16 11:46 UTC (permalink / raw)
  To: pve-devel

Since I had to look up the cause of the error-message in our source
explaining why exactly ceph-operations fail, because
/etc/ceph/ceph.conf exists.

reported via our community forum:
https://forum.proxmox.com/threads/osd-ersetzen-neu-erstellen.80793/

quickly tested on a virtual ceph cluster

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 PVE/Ceph/Tools.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/Ceph/Tools.pm b/PVE/Ceph/Tools.pm
index 12d309be..ab38f7bc 100644
--- a/PVE/Ceph/Tools.pm
+++ b/PVE/Ceph/Tools.pm
@@ -292,7 +292,7 @@ sub setup_pve_symlinks {
     # fail if we find a real file instead of a link
     if (-f $ceph_cfgpath) {
 	my $lnk = readlink($ceph_cfgpath);
-	die "file '$ceph_cfgpath' already exists\n"
+	die "file '$ceph_cfgpath' already exists and is not a symlink to $pve_ceph_cfgpath\n"
 	    if !$lnk || $lnk ne $pve_ceph_cfgpath;
     } else {
 	mkdir $ceph_cfgdir;
-- 
2.20.1





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: Re: [PATCH manager] ceph: extend error for wrong config-file link
  2020-12-16 11:46 [pve-devel] [PATCH manager] ceph: extend error for wrong config-file link Stoiko Ivanov
@ 2020-12-18 16:52 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2020-12-18 16:52 UTC (permalink / raw)
  To: Proxmox VE development discussion, Stoiko Ivanov

On 16/12/2020 12:46, Stoiko Ivanov wrote:
> Since I had to look up the cause of the error-message in our source
> explaining why exactly ceph-operations fail, because
> /etc/ceph/ceph.conf exists.
> 
> reported via our community forum:
> https://forum.proxmox.com/threads/osd-ersetzen-neu-erstellen.80793/
> 
> quickly tested on a virtual ceph cluster
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
>  PVE/Ceph/Tools.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-18 16:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-16 11:46 [pve-devel] [PATCH manager] ceph: extend error for wrong config-file link Stoiko Ivanov
2020-12-18 16:52 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal