From: "Dominic Jäger" <d.jaeger@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-common] JSONSchema: Increase vmid option minimum to 100
Date: Mon, 14 Dec 2020 11:20:52 +0100 [thread overview]
Message-ID: <20201214102052.76711-1-d.jaeger@proxmox.com> (raw)
The API standard_option pve-vmid always checks the format pve-vmid. The format
pve-vmid requires the vmid to be >=100. This is correct, because IDs 1-99 are
reserved.
To display this correctly in the API documentation (API viewer, qm man pages),
we have to set the minimum to 100 in the API standard_option.
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
---
https://forum.proxmox.com/threads/qm-importovf-man-page.80632/
src/PVE/JSONSchema.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm
index 29ada5b..b4596d3 100644
--- a/src/PVE/JSONSchema.pm
+++ b/src/PVE/JSONSchema.pm
@@ -58,7 +58,7 @@ sub get_standard_option {
register_standard_option('pve-vmid', {
description => "The (unique) ID of the VM.",
type => 'integer', format => 'pve-vmid',
- minimum => 1
+ minimum => 100,
});
register_standard_option('pve-node', {
--
2.20.1
next reply other threads:[~2020-12-14 10:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 10:20 Dominic Jäger [this message]
2020-12-14 11:52 ` Thomas Lamprecht
2020-12-14 12:33 ` Fabian Grünbichler
2020-12-15 8:11 ` Dominic Jäger
2020-12-15 8:55 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201214102052.76711-1-d.jaeger@proxmox.com \
--to=d.jaeger@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox