public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Reiter <s.reiter@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [RFC pve-qemu] disable jemalloc
Date: Thu, 10 Dec 2020 16:23:38 +0100	[thread overview]
Message-ID: <20201210152338.19423-1-s.reiter@proxmox.com> (raw)

jemalloc does not play nice with our Rust library (proxmox-backup-qemu),
specifically it never releases memory allocated from Rust to the OS.
This leads to a problem with larger caches (e.g. for the PBS block driver).

It appears to be related to this GitHub issue:
https://github.com/jemalloc/jemalloc/issues/1398

The background_thread solution seems weirdly hacky, so let's disable
jemalloc entirely for now.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
---

@Alexandre: you were the one to introduce jemalloc into our QEMU builds a long
time ago - does it still provide a measurable benefit? If the performance loss
would be too great in removing it, we could maybe figure out some workarounds as
well.

Its current behaviour does seem rather broken to me though...

 debian/rules | 1 -
 1 file changed, 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index c73d6a1..57e1c91 100755
--- a/debian/rules
+++ b/debian/rules
@@ -60,7 +60,6 @@ config.status: configure
 	--enable-docs \
 	--enable-glusterfs \
 	--enable-gnutls \
-	--enable-jemalloc \
 	--enable-libiscsi \
 	--enable-libusb \
 	--enable-linux-aio \
-- 
2.20.1





             reply	other threads:[~2020-12-10 15:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10 15:23 Stefan Reiter [this message]
2020-12-11 15:21 ` alexandre derumier
2020-12-15 13:43 ` [pve-devel] applied: " Thomas Lamprecht
2023-03-10 18:05   ` DERUMIER, Alexandre
2023-03-11  9:01     ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201210152338.19423-1-s.reiter@proxmox.com \
    --to=s.reiter@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal