* [pve-devel] [PATCH qemu-server] clone_disk: fix offline clone of efidisk
@ 2020-12-07 12:15 Fabian Ebner
2020-12-15 13:50 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Ebner @ 2020-12-07 12:15 UTC (permalink / raw)
To: pve-devel
by partially reverting 4df98f2f14348d0ed57529c4c04a1b5ffb840055 and fixing the
line-length issue differently. The commit didn't update two later usages of
$size, breaking copying the efidisk. The other usage as a parameter to
qemu_img_convert() is luckily only cosmetic, for progress output.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
PVE/QemuServer.pm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 70c14ba..607f77b 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -6951,8 +6951,9 @@ sub clone_disk {
} else {
($size) = PVE::Storage::volume_size_info($storecfg, $drive->{file}, 10);
}
- $size /= 1024;
- $newvolid = PVE::Storage::vdisk_alloc($storecfg, $storeid, $newvmid, $dst_format, $name, $size);
+ $newvolid = PVE::Storage::vdisk_alloc(
+ $storecfg, $storeid, $newvmid, $dst_format, $name, ($size/1024)
+ );
push @$newvollist, $newvolid;
PVE::Storage::activate_volumes($storecfg, [$newvolid]);
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread* [pve-devel] applied: [PATCH qemu-server] clone_disk: fix offline clone of efidisk
2020-12-07 12:15 [pve-devel] [PATCH qemu-server] clone_disk: fix offline clone of efidisk Fabian Ebner
@ 2020-12-15 13:50 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2020-12-15 13:50 UTC (permalink / raw)
To: Proxmox VE development discussion, Fabian Ebner
On 07.12.20 13:15, Fabian Ebner wrote:
> by partially reverting 4df98f2f14348d0ed57529c4c04a1b5ffb840055 and fixing the
> line-length issue differently. The commit didn't update two later usages of
> $size, breaking copying the efidisk. The other usage as a parameter to
> qemu_img_convert() is luckily only cosmetic, for progress output.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> PVE/QemuServer.pm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-15 13:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-07 12:15 [pve-devel] [PATCH qemu-server] clone_disk: fix offline clone of efidisk Fabian Ebner
2020-12-15 13:50 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox