From: "Dominic Jäger" <d.jaeger@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server] boot order: Do not use efidisk as default
Date: Thu, 26 Nov 2020 12:13:10 +0100 [thread overview]
Message-ID: <20201126111310.432518-1-d.jaeger@proxmox.com> (raw)
This allows to specify an efidisk during create without specifying
boot order. This enables creating a VM, importing a disk and
afterwards deciding where to attach it:
qm create 102 --bios ovmf --efidisk0 local:0
qm importdisk 102 /root/Windows10.vmdk local
qm set 102 --sata0 local:102/vm-102-disk-1.raw --boot order=sata0
Reported-by: Dominic Jäger <d.jaeger@proxmox.com>
Authored-by: Stefan Reiter <s.reiter@proxmox.com>
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
---
PVE/QemuServer/Drive.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/QemuServer/Drive.pm b/PVE/QemuServer/Drive.pm
index d560937..bb3e990 100644
--- a/PVE/QemuServer/Drive.pm
+++ b/PVE/QemuServer/Drive.pm
@@ -605,6 +605,7 @@ sub resolve_first_disk {
my @disks = valid_drive_names();
foreach my $ds (@disks) {
next if !$conf->{$ds};
+ next if $ds =~m/^efidisk/;
my $disk = parse_drive($ds, $conf->{$ds});
next if drive_is_cdrom($disk) xor $cdrom;
return $ds;
--
2.20.1
reply other threads:[~2020-11-26 11:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201126111310.432518-1-d.jaeger@proxmox.com \
--to=d.jaeger@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox