[pve-devel] [PATCH manager] api: metrics/server: test connection on add/update

[pve-devel] [PATCH manager] api: metrics/server: test connection on add/update

[Dominik Csapak]

just a basic check, but better than not checking at all

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 PVE/API2/Cluster/MetricServer.pm | 5 +++++
 PVE/Status/Plugin.pm             | 7 +++++++
 2 files changed, 12 insertions(+)

diff --git a/PVE/API2/Cluster/MetricServer.pm b/PVE/API2/Cluster/MetricServer.pm
index b96228b0..9a14985e 100644
--- a/PVE/API2/Cluster/MetricServer.pm
+++ b/PVE/API2/Cluster/MetricServer.pm
@@ -159,6 +159,9 @@ __PACKAGE__->register_method ({
 		if $cfg->{ids}->{$id};
 
 	    my $opts = $plugin->check_config($id, $param, 1, 1);
+
+	    $plugin->test_connection($opts);
+
 	    $cfg->{ids}->{$id} = $opts;
 
 	    PVE::Cluster::cfs_write_file('status.cfg', $cfg);
@@ -198,6 +201,8 @@ __PACKAGE__->register_method ({
 	    my $plugin = PVE::Status::Plugin->lookup($data->{type});
 	    my $opts = $plugin->check_config($id, $param, 0, 1);
 
+	    $plugin->test_connection($opts);
+
 	    for my $k (keys %$opts) {
 		$data->{$k} = $opts->{$k};
 	    }
diff --git a/PVE/Status/Plugin.pm b/PVE/Status/Plugin.pm
index 0faf0da6..c3e0bec1 100644
--- a/PVE/Status/Plugin.pm
+++ b/PVE/Status/Plugin.pm
@@ -126,6 +126,13 @@ sub send {
 	or die "failed to send metrics: $!\n";
 }
 
+sub test_connection {
+    my ($class, $cfg) = @_;
+
+    my $conn = $class->_connect($cfg);
+    $class->_disconnect($conn);
+}
+
 sub update_node_status {
     my ($class, $txn, $node, $data, $ctime) = @_;
     die "please implement inside plugin";
-- 
2.20.1

[pve-devel] applied: [PATCH manager] api: metrics/server: test connection on add/update

[Thomas Lamprecht]

On 25.11.20 13:56, Dominik Csapak wrote:
> just a basic check, but better than not checking at all
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  PVE/API2/Cluster/MetricServer.pm | 5 +++++
>  PVE/Status/Plugin.pm             | 7 +++++++
>  2 files changed, 12 insertions(+)
> 
>

applied, thanks!

Re: [pve-devel] [PATCH manager] api: metrics/server: test connection on add/update

[Thomas Lamprecht]

On 25.11.20 13:56, Dominik Csapak wrote:
> just a basic check, but better than not checking at all
> 

so, just had an issue with the network (some test IPv6 LAN here) and had a metric
server configured on that net, thus pvestatd spammed the log with "network
unreachable" messages, and all my resources got the good ol' question mark in the
gui, so far so good.
But, I then tried to disable that ext. metrics entry, but we then *also* do a
connection check which obv. fails ^^

Re: [pve-devel] [PATCH manager] api: metrics/server: test connection on add/update

[Thomas Lamprecht]

On 03.12.20 17:55, Thomas Lamprecht wrote:
> On 25.11.20 13:56, Dominik Csapak wrote:
>> just a basic check, but better than not checking at all
>>
> 
> so, just had an issue with the network (some test IPv6 LAN here) and had a metric
> server configured on that net, thus pvestatd spammed the log with "network
> unreachable" messages, and all my resources got the good ol' question mark in the
> gui, so far so good.
> But, I then tried to disable that ext. metrics entry, but we then *also* do a
> connection check which obv. fails ^^
> 

any news on above?

Re: [pve-devel] [PATCH manager] api: metrics/server: test connection on add/update

[Dominik Csapak]

On 12/7/20 3:30 PM, Thomas Lamprecht wrote:
> On 03.12.20 17:55, Thomas Lamprecht wrote:
>> On 25.11.20 13:56, Dominik Csapak wrote:
>>> just a basic check, but better than not checking at all
>>>
>>
>> so, just had an issue with the network (some test IPv6 LAN here) and had a metric
>> server configured on that net, thus pvestatd spammed the log with "network
>> unreachable" messages, and all my resources got the good ol' question mark in the
>> gui, so far so good.
>> But, I then tried to disable that ext. metrics entry, but we then *also* do a
>> connection check which obv. fails ^^
>>
> 
> any news on above?
> 

oh sorry, i have a patch here, i thought i sent it already...
coming right up ..