* [pve-devel] [PATCH manager] api2/metrics/server: add minimum/maximum port
@ 2020-11-25 11:06 Dominik Csapak
2020-11-25 11:33 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2020-11-25 11:06 UTC (permalink / raw)
To: pve-devel
we just added the api, so it would be good to only accept valid ports
(they were wrapped before)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
PVE/Status/Plugin.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/PVE/Status/Plugin.pm b/PVE/Status/Plugin.pm
index baf670ae..0faf0da6 100644
--- a/PVE/Status/Plugin.pm
+++ b/PVE/Status/Plugin.pm
@@ -36,6 +36,8 @@ my $defaultData = {
port => {
type => 'integer',
description => "server network port",
+ minimum => 1,
+ maximum => 64*1024,
},
mtu => {
type => 'integer',
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager] api2/metrics/server: add minimum/maximum port
2020-11-25 11:06 [pve-devel] [PATCH manager] api2/metrics/server: add minimum/maximum port Dominik Csapak
@ 2020-11-25 11:33 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2020-11-25 11:33 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak
On 25.11.20 12:06, Dominik Csapak wrote:
> we just added the api, so it would be good to only accept valid ports
> (they were wrapped before)
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> PVE/Status/Plugin.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
>
applied, thanks!
side note, can we please use consitently "api: " not "api2/"
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-25 11:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-25 11:06 [pve-devel] [PATCH manager] api2/metrics/server: add minimum/maximum port Dominik Csapak
2020-11-25 11:33 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox