From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 1/2] api2: osd destroy: fix error function
Date: Tue, 24 Nov 2020 19:55:46 +0100 [thread overview]
Message-ID: <20201124185547.8832-2-s.ivanov@proxmox.com> (raw)
In-Reply-To: <20201124185547.8832-1-s.ivanov@proxmox.com>
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
PVE/API2/Ceph/OSD.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/API2/Ceph/OSD.pm b/PVE/API2/Ceph/OSD.pm
index f1f39bf9..685b68bc 100644
--- a/PVE/API2/Ceph/OSD.pm
+++ b/PVE/API2/Ceph/OSD.pm
@@ -575,7 +575,7 @@ __PACKAGE__->register_method ({
# try to remove pvs, but do not fail if it does not work
for my $osd_part (@{$osd_list->{$osdid}}) {
for my $dev (@{$osd_part->{devices}}) {
- eval { run_command(['/sbin/pvremove', $dev], errfunc => {}) };
+ eval { run_command(['/sbin/pvremove', $dev], errfunc => sub {}) };
warn $@ if $@;
}
}
--
2.20.1
next prev parent reply other threads:[~2020-11-24 18:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 18:55 [pve-devel] [PATCH manager 0/2] fix small glitch in OSD destruction due to tainting Stoiko Ivanov
2020-11-24 18:55 ` Stoiko Ivanov [this message]
2020-11-24 18:55 ` [pve-devel] [PATCH manager 2/2] api2: osd destroy: untaint device before pvremove Stoiko Ivanov
2020-11-25 10:03 ` [pve-devel] applied: [PATCH manager 0/2] fix small glitch in OSD destruction due to tainting Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201124185547.8832-2-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox