From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Alexandre Derumier <aderumier@odiso.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH qemu-server 1/3] add PVE::QemuServer::Cgroup
Date: Tue, 24 Nov 2020 12:09:04 +0100 [thread overview]
Message-ID: <20201124110904.wz4unalnywyecfho@wobu-vie.proxmox.com> (raw)
In-Reply-To: <20201030094236.53483-2-aderumier@odiso.com>
qemu doesn't actually have a limiting namespace subdirectory, so I'll
just replace this with:
sub get_subdir {
my ($self, $controller, $limiting) = @_;
my $vmid = $self->{vmid};
return "qemu.slice/$vmid.scope/";
}
On Fri, Oct 30, 2020 at 10:42:34AM +0100, Alexandre Derumier wrote:
> ---
> PVE/QemuServer/CGroup.pm | 25 +++++++++++++++++++++++++
> PVE/QemuServer/Makefile | 1 +
> 2 files changed, 26 insertions(+)
> create mode 100644 PVE/QemuServer/CGroup.pm
>
> diff --git a/PVE/QemuServer/CGroup.pm b/PVE/QemuServer/CGroup.pm
> new file mode 100644
> index 0000000..7ca0826
> --- /dev/null
> +++ b/PVE/QemuServer/CGroup.pm
> @@ -0,0 +1,25 @@
> +package PVE::QemuServer::CGroup;
> +
> +use strict;
> +use warnings;
> +use PVE::CGroup;
> +use base('PVE::CGroup');
> +
> +sub get_subdir {
> + my ($self, $controller, $limiting) = @_;
> +
> + my $entry_name = $controller || 'unified';
> + my $entry = ($self->{controllers}->{$entry_name} //= {});
> +
> + my $kind = $limiting ? 'limit' : 'ns';
> + my $path = $entry->{$kind};
> +
> + return $path if defined $path;
> +
> + my $vmid = $self->{vmid};
> + $path = "qemu.slice/$vmid.scope/";
> +
> + return $path;
> +}
> +
> +1;
> diff --git a/PVE/QemuServer/Makefile b/PVE/QemuServer/Makefile
> index fd8cfbb..e4ed184 100644
> --- a/PVE/QemuServer/Makefile
> +++ b/PVE/QemuServer/Makefile
> @@ -9,6 +9,7 @@ SOURCES=PCI.pm \
> Monitor.pm \
> Machine.pm \
> CPUConfig.pm \
> + CGroup.pm \
> Drive.pm \
>
> .PHONY: install
> --
> 2.20.1
next prev parent reply other threads:[~2020-11-24 11:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 9:42 [pve-devel] [PATCH qemu-server 0/3] use generic CGroup module Alexandre Derumier
2020-10-30 9:42 ` [pve-devel] [PATCH qemu-server 1/3] add PVE::QemuServer::Cgroup Alexandre Derumier
2020-11-24 11:09 ` Wolfgang Bumiller [this message]
2020-10-30 9:42 ` [pve-devel] [PATCH qemu-server 2/3] replace cgroups_write by cgroup change_cpu_shares && change_cpu_quota Alexandre Derumier
2020-10-30 9:42 ` [pve-devel] [PATCH qemu-server 3/3] systemd scope: add CPUWeight for cgroupv2 Alexandre Derumier
2020-11-24 11:09 ` [pve-devel] applied 2&3: [PATCH qemu-server 0/3] use generic CGroup module Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201124110904.wz4unalnywyecfho@wobu-vie.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=aderumier@odiso.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox