From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH guest-common] vzdump: print prune-backups options in command_line correctly
Date: Tue, 24 Nov 2020 11:14:38 +0100 [thread overview]
Message-ID: <20201124101438.19535-1-f.ebner@proxmox.com> (raw)
Otherwise it prints the hash reference instead of the prune options.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
AFAICT the result of the function was only used for printing, so this
should've been a cosmetic problem only.
PVE/VZDump/Common.pm | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/PVE/VZDump/Common.pm b/PVE/VZDump/Common.pm
index 63a4689..648c906 100644
--- a/PVE/VZDump/Common.pm
+++ b/PVE/VZDump/Common.pm
@@ -377,6 +377,10 @@ sub command_line {
foreach my $path (split(/\0/, $v || '')) {
$cmd .= " --$p " . PVE::Tools::shellquote($path);
}
+ } elsif ($p eq 'prune-backups') {
+ my $property_string = PVE::JSONSchema::print_property_string($v, 'prune-backups');
+ $cmd .= " --$p " . PVE::Tools::shellquote($property_string)
+ if defined($property_string) && $property_string ne '';
} else {
$cmd .= " --$p " . PVE::Tools::shellquote($v) if defined($v) && $v ne '';
}
--
2.20.1
next reply other threads:[~2020-11-24 10:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 10:14 Fabian Ebner [this message]
2020-11-24 10:32 ` Fabian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201124101438.19535-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox