From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v2 1/3] ui: change comment column to notes
Date: Tue, 24 Nov 2020 10:09:34 +0100 [thread overview]
Message-ID: <20201124090936.21810-7-d.csapak@proxmox.com> (raw)
In-Reply-To: <20201124090936.21810-1-d.csapak@proxmox.com>
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/grid/BackupView.js | 4 ++--
www/manager6/storage/Browser.js | 2 +-
www/manager6/storage/ContentView.js | 12 ++++++------
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/www/manager6/grid/BackupView.js b/www/manager6/grid/BackupView.js
index ec0b60b2..191b2e3f 100644
--- a/www/manager6/grid/BackupView.js
+++ b/www/manager6/grid/BackupView.js
@@ -238,8 +238,8 @@ Ext.define('PVE.grid.BackupView', {
dataIndex: 'volid'
},
{
- header: gettext('Comment'),
- dataIndex: 'comment',
+ header: gettext('Notes'),
+ dataIndex: 'notes',
flex: 1,
renderer: Ext.htmlEncode,
},
diff --git a/www/manager6/storage/Browser.js b/www/manager6/storage/Browser.js
index 64c492d8..6efa0e65 100644
--- a/www/manager6/storage/Browser.js
+++ b/www/manager6/storage/Browser.js
@@ -53,7 +53,7 @@ Ext.define('PVE.storage.Browser', {
title: gettext('Backups'),
iconCls: 'fa fa-floppy-o',
itemId: 'contentBackup',
- hasCommentColumn: true,
+ hasNotesColumn: true,
});
}
if (contents.includes('images')) {
diff --git a/www/manager6/storage/ContentView.js b/www/manager6/storage/ContentView.js
index eb487553..a5e4cdee 100644
--- a/www/manager6/storage/ContentView.js
+++ b/www/manager6/storage/ContentView.js
@@ -333,11 +333,11 @@ Ext.define('PVE.storage.ContentView', {
renderer: PVE.Utils.render_storage_content,
dataIndex: 'text',
},
- 'comment': {
- header: gettext('Comment'),
+ 'notes': {
+ header: gettext('Notes'),
flex: 1,
renderer: Ext.htmlEncode,
- dataIndex: 'comment',
+ dataIndex: 'notes',
},
'date': {
header: gettext('Date'),
@@ -359,8 +359,8 @@ Ext.define('PVE.storage.ContentView', {
if (me.hideColumns) {
me.hideColumns.forEach(key => delete availableColumns[key]);
- } else if (!me.hasCommentColumn) {
- delete availableColumns.comment;
+ } else if (!me.hasNotesColumn) {
+ delete availableColumns.notes;
}
const columns = Object.values(availableColumns);
@@ -381,7 +381,7 @@ Ext.define('PVE.storage.ContentView', {
extend: 'Ext.data.Model',
fields: [
'volid', 'content', 'format', 'size', 'used', 'vmid',
- 'channel', 'id', 'lun', 'comment', 'verification',
+ 'channel', 'id', 'lun', 'notes', 'verification',
{
name: 'text',
convert: function(value, record) {
--
2.20.1
next prev parent reply other threads:[~2020-11-24 9:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 9:09 [pve-devel] [PATCH proxmox-backup/pve-storage/pve-manager v2] show/edit backup comments Dominik Csapak
2020-11-24 9:09 ` [pve-devel] [PATCH proxmox-backup v2 1/1] client: add 'snapshot notes show/update' command Dominik Csapak
2020-11-24 9:52 ` Wolfgang Bumiller
2020-11-24 12:28 ` [pve-devel] applied: [pbs-devel] " Dietmar Maurer
2020-11-24 9:09 ` [pve-devel] [PATCH storage v2 1/4] rename comment to notes Dominik Csapak
2020-11-24 9:09 ` [pve-devel] [PATCH storage v2 2/4] api2/storage/content: change to volume_size_info and add return properties Dominik Csapak
2020-11-24 9:09 ` [pve-devel] [PATCH storage v2 3/4] Storage/Plugin: add get/update_volume_comment and implement for dir Dominik Csapak
2020-11-24 9:09 ` [pve-devel] [PATCH storage v2 4/4] Storage/PBSPlugin: implement get/update_volume_notes for pbs Dominik Csapak
2020-11-24 9:09 ` Dominik Csapak [this message]
2020-11-24 9:09 ` [pve-devel] [PATCH manager v2 2/3] ui: add ability to show and edit comments for backups Dominik Csapak
2020-11-24 9:09 ` [pve-devel] [PATCH manager v2 3/3] ui: enable notesedit for pbs Dominik Csapak
2021-03-25 8:22 ` [pve-devel] applied: " Thomas Lamprecht
2020-11-24 13:11 ` [pve-devel] applied-partially: [PATCH proxmox-backup/pve-storage/pve-manager v2] show/edit backup comments Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201124090936.21810-7-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox