public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-backup/pve-storage/pve-manager v2] show/edit backup comments
Date: Tue, 24 Nov 2020 10:09:28 +0100	[thread overview]
Message-ID: <20201124090936.21810-1-d.csapak@proxmox.com> (raw)

implement editing/showing notes from pve side
for directory and pbs storages

this series technically consists of a breaking api change
(comments -> notes) in content listing, but since we only just built
packages with the relevant commits, this should be ok...

i also omitted the suggested 'snapshot list' part of proxmox-backup
but will look into implementing an invisible alias for the clicommand
in rust soon

changes from v1:
* rename all occurences of 'comment' to 'notes' where possible
(everywhere except the snapshots api of pbs)
* split patches so that pbs ones could be applied later

apply order/dependency:

pbs patches (can be applied later):
pve-manager 3/3 depends on pve-storage 4/4 depends on proxmxo-backup

else:
pve-manager 1/3 depends on pve-storage 1/4
pve-manager 2/3 depends on pve-storage 2,3/4

proxmox-backup:

Dominik Csapak (1):
  client: add 'snapshot notes show/update' command

 src/bin/proxmox-backup-client.rs          |   1 +
 src/bin/proxmox_backup_client/mod.rs      |   2 +
 src/bin/proxmox_backup_client/snapshot.rs | 126 ++++++++++++++++++++++
 3 files changed, 129 insertions(+)
 create mode 100644 src/bin/proxmox_backup_client/snapshot.rs

pve-storage:

Dominik Csapak (4):
  rename comment to notes
  api2/storage/content: change to volume_size_info and add return
    properties
  Storage/Plugin: add get/update_volume_comment and implement for dir
  Storage/PBSPlugin: implement get/update_volume_notes for pbs

 PVE/API2/Storage/Content.pm | 96 ++++++++++++++++++++++++++++++++++---
 PVE/Storage.pm              | 20 ++++++++
 PVE/Storage/DirPlugin.pm    | 30 ++++++++++++
 PVE/Storage/PBSPlugin.pm    | 22 ++++++++-
 PVE/Storage/Plugin.pm       | 22 +++++++--
 5 files changed, 177 insertions(+), 13 deletions(-)

pve-manager:

Dominik Csapak (3):
  ui: change comment column to notes
  ui: add ability to show and edit comments for backups
  ui: enable notesedit for pbs

 www/manager6/grid/BackupView.js     | 47 +++++++++++++++++++++++++++--
 www/manager6/storage/Browser.js     |  2 +-
 www/manager6/storage/ContentView.js | 12 ++++----
 3 files changed, 51 insertions(+), 10 deletions(-)

-- 
2.20.1





             reply	other threads:[~2020-11-24  9:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-24  9:09 Dominik Csapak [this message]
2020-11-24  9:09 ` [pve-devel] [PATCH proxmox-backup v2 1/1] client: add 'snapshot notes show/update' command Dominik Csapak
2020-11-24  9:52   ` Wolfgang Bumiller
2020-11-24 12:28   ` [pve-devel] applied: [pbs-devel] " Dietmar Maurer
2020-11-24  9:09 ` [pve-devel] [PATCH storage v2 1/4] rename comment to notes Dominik Csapak
2020-11-24  9:09 ` [pve-devel] [PATCH storage v2 2/4] api2/storage/content: change to volume_size_info and add return properties Dominik Csapak
2020-11-24  9:09 ` [pve-devel] [PATCH storage v2 3/4] Storage/Plugin: add get/update_volume_comment and implement for dir Dominik Csapak
2020-11-24  9:09 ` [pve-devel] [PATCH storage v2 4/4] Storage/PBSPlugin: implement get/update_volume_notes for pbs Dominik Csapak
2020-11-24  9:09 ` [pve-devel] [PATCH manager v2 1/3] ui: change comment column to notes Dominik Csapak
2020-11-24  9:09 ` [pve-devel] [PATCH manager v2 2/3] ui: add ability to show and edit comments for backups Dominik Csapak
2020-11-24  9:09 ` [pve-devel] [PATCH manager v2 3/3] ui: enable notesedit for pbs Dominik Csapak
2021-03-25  8:22   ` [pve-devel] applied: " Thomas Lamprecht
2020-11-24 13:11 ` [pve-devel] applied-partially: [PATCH proxmox-backup/pve-storage/pve-manager v2] show/edit backup comments Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201124090936.21810-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal