public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH xtermjs] fix #2980: do not prompt for leaving on reconnect/disconnect
Date: Mon, 23 Nov 2020 16:41:50 +0100	[thread overview]
Message-ID: <20201123154150.2129-1-d.csapak@proxmox.com> (raw)

this includes migration detection

basically we should only enable this when we are fully connected

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/www/main.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/www/main.js b/src/www/main.js
index a3713f4..c2811f6 100644
--- a/src/www/main.js
+++ b/src/www/main.js
@@ -39,11 +39,13 @@ function updateState(newState, msg, code) {
 	    message = "Connected";
 	    break;
 	case states.disconnecting:
+	    window.onbeforeunload = undefined;
 	    message = "Disconnecting...";
 	    timeout = 0;
 	    severity = severities.warning;
 	    break;
 	case states.reconnecting:
+	    window.onbeforeunload = undefined;
 	    message = "Reconnecting...";
 	    timeout = 0;
 	    severity = severities.warning;
-- 
2.20.1





             reply	other threads:[~2020-11-23 15:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-23 15:41 Dominik Csapak [this message]
2020-11-24 13:42 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201123154150.2129-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal