public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit 2/2 v3] InputPanel: remove old code for useFieldContainer
Date: Tue, 17 Nov 2020 14:50:43 +0100	[thread overview]
Message-ID: <20201117135043.30933-2-a.lauterer@proxmox.com> (raw)
In-Reply-To: <20201117135043.30933-1-a.lauterer@proxmox.com>

`useFieldContainer` doesn't seem to be used anymore in any of our
products:
* PVE
* PMG
* PBS

it therefore can be considered dead code.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
v3: added newly after discussing on the mailing list that this is
probably dead code [0]

[0] https://lists.proxmox.com/pipermail/pve-devel/2020-November/045968.html
 src/panel/InputPanel.js | 27 ++++++++-------------------
 1 file changed, 8 insertions(+), 19 deletions(-)

diff --git a/src/panel/InputPanel.js b/src/panel/InputPanel.js
index f132005..ed3521a 100644
--- a/src/panel/InputPanel.js
+++ b/src/panel/InputPanel.js
@@ -225,25 +225,14 @@ Ext.define('Proxmox.panel.InputPanel', {
 	    });
 	}
 
-	if (me.useFieldContainer) {
-	    Ext.apply(me, {
-		layout: 'fit',
-		items: Ext.apply(me.useFieldContainer, {
-		    layout: 'column',
-		    defaultType: 'container',
-		    items: items,
-		}),
-	    });
-	} else {
-	    Ext.apply(me, {
-		layout: {
-		    type: 'vbox',
-		    align: 'stretch',
-		},
-		defaultType: 'container',
-		items: items,
-	    });
-	}
+	Ext.apply(me, {
+	    layout: {
+		type: 'vbox',
+		align: 'stretch',
+	    },
+	    defaultType: 'container',
+	    items: items,
+	});
 
 	me.callParent();
     },
-- 
2.20.1





  reply	other threads:[~2020-11-17 13:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-17 13:50 [pve-devel] [PATCH widget-toolkit 1/2 v3] InputPanel: fix column scaling behavior Aaron Lauterer
2020-11-17 13:50 ` Aaron Lauterer [this message]
2020-11-19 11:51 ` [pve-devel] applied: " Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201117135043.30933-2-a.lauterer@proxmox.com \
    --to=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal