From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Thomas Legay <thomas@lgy.fr>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [Allow snapshot backup with glusterfs 0/1]
Date: Fri, 13 Nov 2020 15:12:10 +0100 [thread overview]
Message-ID: <20201113151210.02c9de62@rosa.proxmox.com> (raw)
In-Reply-To: <20201112184839.391060-1-thomas@lgy.fr>
Hi,
Thank you for contributing to PVE!
Could you explain what the patch fixes and why it works (would also be
great to have that information in the commit-message)?
I checked our bugzilla and the community forum, but could not find any
recent issue regarding gluster and containers (I probably overlooked it).
AFAICT the patch disables running syncfs(2) on the gluster fuse-mount used
for containers. Does the syncfs call fail? What error do you get?
The syncfs call is there to ensure that the backup is consistent as far as
possible - so I would not disable it without rationale.
On another note - we would need a signed CLA from you, in order to be able
to include your code in our codebase - see [0].
Best Regards,
stoiko
[0]
https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright
On Thu, 12 Nov 2020 19:48:38 +0100
Thomas Legay <thomas@lgy.fr> wrote:
> Thomas Legay (1):
> Allow LXC snapshot backup with glusterfs mount point
>
> src/PVE/LXC.pm | 1 +
> 1 file changed, 1 insertion(+)
>
next prev parent reply other threads:[~2020-11-13 14:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 18:48 Thomas Legay
2020-11-12 18:48 ` [pve-devel] [PATCH pve-container] Allow LXC snapshot backup with glusterfs mount point Thomas Legay
2020-11-13 14:12 ` Stoiko Ivanov [this message]
2020-11-14 0:31 ` [pve-devel] [Allow snapshot backup with glusterfs 0/1] Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113151210.02c9de62@rosa.proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=thomas@lgy.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox