public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] ui: remove sum for percentages of ceph pools
@ 2020-11-13 12:01 Dominik Csapak
  2020-11-16  9:13 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2020-11-13 12:01 UTC (permalink / raw)
  To: pve-devel

because different pools can have different crush rules, etc.
the sum of the 'percentage used' column makes no real sense, so we
remove it

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/ceph/Pool.js | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js
index 11bcf9d5..271dcc3c 100644
--- a/www/manager6/ceph/Pool.js
+++ b/www/manager6/ceph/Pool.js
@@ -164,10 +164,6 @@ Ext.define('PVE.node.CephPoolList', {
 			return Ext.util.Format.percent(val, '0.00');
 		    },
 		    dataIndex: 'percent_used',
-		    summaryType: 'sum',
-		    summaryRenderer: function(val) {
-			return Ext.util.Format.percent(val, '0.00');
-		    },
 		},
 		{
 		    text: gettext('Total'),
-- 
2.20.1





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH manager] ui: remove sum for percentages of ceph pools
  2020-11-13 12:01 [pve-devel] [PATCH manager] ui: remove sum for percentages of ceph pools Dominik Csapak
@ 2020-11-16  9:13 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2020-11-16  9:13 UTC (permalink / raw)
  To: Proxmox VE development discussion, Dominik Csapak

On 13.11.20 13:01, Dominik Csapak wrote:
> because different pools can have different crush rules, etc.
> the sum of the 'percentage used' column makes no real sense, so we
> remove it
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/manager6/ceph/Pool.js | 4 ----
>  1 file changed, 4 deletions(-)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-16  9:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-13 12:01 [pve-devel] [PATCH manager] ui: remove sum for percentages of ceph pools Dominik Csapak
2020-11-16  9:13 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal