public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Oguz Bektas <o.bektas@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer] don't configure vt keyboard during installation
Date: Mon,  9 Nov 2020 16:17:30 +0100	[thread overview]
Message-ID: <20201109151730.1088969-1-o.bektas@proxmox.com> (raw)

in create_country_view() when setting the keyboard config
setupcon is too slow, causing installer to hang for some
seconds when switching to/from country view.

setxkbmap is enough during the installation (next step
password & email works fine with different keymaps), vt
is largely unused during it anyway.

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
 proxinstall | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/proxinstall b/proxinstall
index dd06727..9879df4 100755
--- a/proxinstall
+++ b/proxinstall
@@ -2751,14 +2751,6 @@ sub create_country_view {
 
 	    if (! $opt_testmode) {
 		syscmd ("setxkbmap $xkmap $xvar");
-		my $kbd_config = qq{
-		    XKBLAYOUT="$xkmap"
-		    XKBVARIANT="$xvar"
-		    BACKSPACE="guess"
-		};
-		$kbd_config =~ s/^\s+//gm;
-		write_config($kbd_config, '/etc/default/keyboard');
-		syscmd ("setupcon");
 	    }
 	}
     });
-- 
2.20.1




             reply	other threads:[~2020-11-09 15:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-09 15:17 Oguz Bektas [this message]
2020-11-09 18:57 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201109151730.1088969-1-o.bektas@proxmox.com \
    --to=o.bektas@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal