From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 container 2/5] adapt to new storage_migrate activation behavior
Date: Fri, 6 Nov 2020 15:30:56 +0100 [thread overview]
Message-ID: <20201106143059.22047-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20201106143059.22047-1-f.ebner@proxmox.com>
Every local volume is migrated via storage_migrate and activated there,
so there is no need to do it in prepare() anymore.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
dependency bump needed
I only found run_replication as a potential place that might need
active local volumes, but that also uses storage_migrate in the end.
src/PVE/LXC/Migrate.pm | 6 ------
1 file changed, 6 deletions(-)
diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm
index 90d74b4..94a78c5 100644
--- a/src/PVE/LXC/Migrate.pm
+++ b/src/PVE/LXC/Migrate.pm
@@ -45,7 +45,6 @@ sub prepare {
$self->{was_running} = $running;
my $force = $self->{opts}->{force} // 0;
- my $need_activate = [];
PVE::LXC::Config->foreach_volume($conf, sub {
my ($ms, $mountpoint) = @_;
@@ -80,9 +79,6 @@ sub prepare {
warn "Used shared storage '$storage' is not online on source node!\n"
if !$plugin->check_connection($storage, $scfg);
} else {
- # only activate if not shared
- push @$need_activate, $volid;
-
# unless in restart mode because we shut the container down
die "unable to migrate local mount point '$volid' while CT is running"
if $running && !$restart;
@@ -90,8 +86,6 @@ sub prepare {
});
- PVE::Storage::activate_volumes($self->{storecfg}, $need_activate);
-
# todo: test if VM uses local resources
# test ssh connection
--
2.20.1
next prev parent reply other threads:[~2020-11-06 14:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 14:30 [pve-devel] [PATCH v2 storage 1/5] fix #3030: always activate volumes in storage_migrate Fabian Ebner
2020-11-06 14:30 ` Fabian Ebner [this message]
2020-11-10 18:29 ` [pve-devel] applied: [PATCH v2 container 2/5] adapt to new storage_migrate activation behavior Thomas Lamprecht
2020-11-06 14:30 ` [pve-devel] [RFC v2 container 3/5] deactivate volumes after storage_migrate Fabian Ebner
2020-11-24 15:26 ` [pve-devel] applied: " Fabian Grünbichler
2020-11-06 14:30 ` [pve-devel] [RFC v2 qemu-server 4/5] adapt to new storage_migrate activation behavior Fabian Ebner
2020-11-24 15:29 ` [pve-devel] applied: " Fabian Grünbichler
2020-11-06 14:30 ` [pve-devel] [RFC v2 qemu-server 5/5] deactivate volumes after storage_migrate Fabian Ebner
2020-11-24 15:29 ` [pve-devel] applied: " Fabian Grünbichler
2020-11-10 18:12 ` [pve-devel] applied: [PATCH v2 storage 1/5] fix #3030: always activate volumes in storage_migrate Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201106143059.22047-2-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox