* [pve-devel] [PATCH pve-container 0/1] vmstatus: add pressure stats
@ 2020-11-04 1:42 Alexandre Derumier
2020-11-04 1:42 ` [pve-devel] [PATCH pve-container 1/1] " Alexandre Derumier
0 siblings, 1 reply; 4+ messages in thread
From: Alexandre Derumier @ 2020-11-04 1:42 UTC (permalink / raw)
To: pve-devel
need pve-common patches serie
Alexandre Derumier (1):
vmstatus: add pressure stats
src/PVE/LXC.pm | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pve-devel] [PATCH pve-container 1/1] vmstatus: add pressure stats
2020-11-04 1:42 [pve-devel] [PATCH pve-container 0/1] vmstatus: add pressure stats Alexandre Derumier
@ 2020-11-04 1:42 ` Alexandre Derumier
2021-02-06 14:12 ` Thomas Lamprecht
0 siblings, 1 reply; 4+ messages in thread
From: Alexandre Derumier @ 2020-11-04 1:42 UTC (permalink / raw)
To: pve-devel
---
src/PVE/LXC.pm | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 5cfcf28..ad1460c 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -291,6 +291,24 @@ sub vmstatus {
} else {
$d->{cpu} = 0;
}
+
+ if (defined(my $pressure = $cgroups->get_pressure_stat())) {
+ $d->{pressure} = $pressure;
+ } else {
+ $d->{pressure} = {
+ cpu => {
+ some => { avg10 => 10, avg60 => 0, avg300 => 0 }
+ },
+ memory => {
+ some => { avg10 => 10, avg60 => 0, avg300 => 0 },
+ full => { avg10 => 10, avg60 => 0, avg300 => 0 }
+ },
+ io => {
+ some => { avg10 => 10, avg60 => 0, avg300 => 0 },
+ full => { avg10 => 10, avg60 => 0, avg300 => 0 }
+ },
+ };
+ }
}
my $netdev = PVE::ProcFSTools::read_proc_net_dev();
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pve-devel] [PATCH pve-container 1/1] vmstatus: add pressure stats
2020-11-04 1:42 ` [pve-devel] [PATCH pve-container 1/1] " Alexandre Derumier
@ 2021-02-06 14:12 ` Thomas Lamprecht
2021-02-07 13:42 ` aderumier
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Lamprecht @ 2021-02-06 14:12 UTC (permalink / raw)
To: Proxmox VE development discussion, Alexandre Derumier
sorry for the late reply!
On 04.11.20 02:42, Alexandre Derumier wrote:
> ---
> src/PVE/LXC.pm | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
> index 5cfcf28..ad1460c 100644
> --- a/src/PVE/LXC.pm
> +++ b/src/PVE/LXC.pm
> @@ -291,6 +291,24 @@ sub vmstatus {
> } else {
> $d->{cpu} = 0;
> }
> +
> + if (defined(my $pressure = $cgroups->get_pressure_stat())) {
> + $d->{pressure} = $pressure;
> + } else {
> + $d->{pressure} = {
> + cpu => {
> + some => { avg10 => 10, avg60 => 0, avg300 => 0 }
Setting avg10 to 10 seems wrong?
> + },
> + memory => {
> + some => { avg10 => 10, avg60 => 0, avg300 => 0 },
> + full => { avg10 => 10, avg60 => 0, avg300 => 0 }
> + },
> + io => {
> + some => { avg10 => 10, avg60 => 0, avg300 => 0 },
> + full => { avg10 => 10, avg60 => 0, avg300 => 0 }
> + },
> + };
> + }
> }
>
> my $netdev = PVE::ProcFSTools::read_proc_net_dev();
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pve-devel] [PATCH pve-container 1/1] vmstatus: add pressure stats
2021-02-06 14:12 ` Thomas Lamprecht
@ 2021-02-07 13:42 ` aderumier
0 siblings, 0 replies; 4+ messages in thread
From: aderumier @ 2021-02-07 13:42 UTC (permalink / raw)
To: Thomas Lamprecht, Proxmox VE development discussion
Le samedi 06 février 2021 à 15:12 +0100, Thomas Lamprecht a écrit :
>
> Setting avg10 to 10 seems wrong?
Sorry, I think it's was some debug value when I was testing it.
I have resend both pve-common && pve-container patches.
Thanks for the review !
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-07 13:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-04 1:42 [pve-devel] [PATCH pve-container 0/1] vmstatus: add pressure stats Alexandre Derumier
2020-11-04 1:42 ` [pve-devel] [PATCH pve-container 1/1] " Alexandre Derumier
2021-02-06 14:12 ` Thomas Lamprecht
2021-02-07 13:42 ` aderumier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox