public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit] InputPanel: fix column scaling behavior
Date: Fri, 30 Oct 2020 13:48:38 +0100	[thread overview]
Message-ID: <20201030124838.23655-2-a.lauterer@proxmox.com> (raw)
In-Reply-To: <20201030124838.23655-1-a.lauterer@proxmox.com>

When scaling the browsers content either via the browser itself or
because the OS has a different scaling / DPI setting, it can happen that
not all columns have enough space next to each other and thus the last
column is moved further below.

This happens especially on chromium bases browsers (e.g. chrome, edge).

Setting the column width a tiny bit smaller helps to avoid this problem.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
 src/panel/InputPanel.js | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/panel/InputPanel.js b/src/panel/InputPanel.js
index 0ac5e48..305bcad 100644
--- a/src/panel/InputPanel.js
+++ b/src/panel/InputPanel.js
@@ -95,25 +95,25 @@ Ext.define('Proxmox.panel.InputPanel', {
 	    me.columns = 4;
 	    items = [
 		{
-		    columnWidth: 0.25,
+		    columnWidth: 0.249,
 		    padding: '0 10 0 0',
 		    layout: 'anchor',
 		    items: me.column1,
 		},
 		{
-		    columnWidth: 0.25,
+		    columnWidth: 0.249,
 		    padding: '0 10 0 0',
 		    layout: 'anchor',
 		    items: me.column2,
 		},
 		{
-		    columnWidth: 0.25,
+		    columnWidth: 0.249,
 		    padding: '0 10 0 0',
 		    layout: 'anchor',
 		    items: me.column3,
 		},
 		{
-		    columnWidth: 0.25,
+		    columnWidth: 0.249,
 		    padding: '0 0 0 10',
 		    layout: 'anchor',
 		    items: me.column4,
@@ -131,13 +131,13 @@ Ext.define('Proxmox.panel.InputPanel', {
 	    me.columns = 2;
 	    items = [
 		{
-		    columnWidth: 0.5,
+		    columnWidth: 0.495,
 		    padding: '0 10 0 0',
 		    layout: 'anchor',
 		    items: me.column1,
 		},
 		{
-		    columnWidth: 0.5,
+		    columnWidth: 0.495,
 		    padding: '0 0 0 10',
 		    layout: 'anchor',
 		    items: me.column2 || [], // allow empty column
-- 
2.20.1





  reply	other threads:[~2020-10-30 12:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-30 12:48 [pve-devel] [PATCH manager] ui: fix column behavior with browser scaling Aaron Lauterer
2020-10-30 12:48 ` Aaron Lauterer [this message]
2020-11-02 10:07 ` Aaron Lauterer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201030124838.23655-2-a.lauterer@proxmox.com \
    --to=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal