public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Alexandre Derumier <aderumier@odiso.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server 3/3] systemd scope: add CPUWeight for cgroupv2
Date: Fri, 30 Oct 2020 10:42:36 +0100	[thread overview]
Message-ID: <20201030094236.53483-4-aderumier@odiso.com> (raw)
In-Reply-To: <20201030094236.53483-1-aderumier@odiso.com>

---
 PVE/QemuServer.pm | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 1fd6338..af74d64 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -5064,10 +5064,15 @@ sub vm_start_nolock {
 
     my %properties = (
 	Slice => 'qemu.slice',
-	KillMode => 'none',
-	CPUShares => $cpuunits
+	KillMode => 'none'
     );
 
+    if (PVE::CGroup::cgroup_mode() == 2) {
+	$properties{CPUWeight} = $cpuunits;
+    } else {
+	$properties{CPUShares} = $cpuunits;
+    }
+
     if (my $cpulimit = $conf->{cpulimit}) {
 	$properties{CPUQuota} = int($cpulimit * 100);
     }
-- 
2.20.1




  parent reply	other threads:[~2020-10-30  9:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-30  9:42 [pve-devel] [PATCH qemu-server 0/3] use generic CGroup module Alexandre Derumier
2020-10-30  9:42 ` [pve-devel] [PATCH qemu-server 1/3] add PVE::QemuServer::Cgroup Alexandre Derumier
2020-11-24 11:09   ` Wolfgang Bumiller
2020-10-30  9:42 ` [pve-devel] [PATCH qemu-server 2/3] replace cgroups_write by cgroup change_cpu_shares && change_cpu_quota Alexandre Derumier
2020-10-30  9:42 ` Alexandre Derumier [this message]
2020-11-24 11:09 ` [pve-devel] applied 2&3: [PATCH qemu-server 0/3] use generic CGroup module Wolfgang Bumiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201030094236.53483-4-aderumier@odiso.com \
    --to=aderumier@odiso.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal