From: Stefan Reiter <s.reiter@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 0/6] QEMU backup cancellation fixes
Date: Thu, 29 Oct 2020 14:10:30 +0100 [thread overview]
Message-ID: <20201029131036.11786-1-s.reiter@proxmox.com> (raw)
Some bugfixes for qmp_backup_cancel and create_backup_jobs, that would lead to
VM hangs, wrongly aborted backups or missing/bad error messages.
Now tested with all permutations of
* one vs two disks
* iothread enabled/disabled per disk
and running
until sudo timeout -s SIGTERM 5s vzdump 100 --storage pbs; do; done
during lunch :)
Sent as seperate patches for review, last patch is for pve-qemu and contains the
changes squashed in with only one new file.
v2:
* fix some more issues (patches 1 and 5)
* fix releasing wrong AioContext after job_cancel_sync
* add patch-of-patches for easier apply
qemu: Stefan Reiter (5):
PVE: fixup: drop CoMutex on error return
PVE: Introduce generic CoCtxData struct
PVE: Don't expect complete_cb to be called outside coroutine
PVE: Don't call job_cancel in coroutines
PVE: fix and clean up error handling for create_backup_jobs
proxmox-backup-client.c | 20 +++-----
proxmox-backup-client.h | 6 +++
pve-backup.c | 111 +++++++++++++++++++++++++++++-----------
3 files changed, 93 insertions(+), 44 deletions(-)
qemu: Stefan Reiter (1):
Several fixes for backup abort and error reporting
...ckup-proxmox-backup-patches-for-qemu.patch | 41 ++--
...irty-bitmap-tracking-for-incremental.patch | 10 +-
...ct-stderr-to-journal-when-daemonized.patch | 2 +
...d-sequential-job-transaction-support.patch | 1 +
...-transaction-to-synchronize-job-stat.patch | 2 +
...ore-coroutines-and-don-t-block-on-fi.patch | 94 +++++----
...n-up-error-handling-for-create_backu.patch | 187 ++++++++++++++++++
debian/patches/series | 1 +
8 files changed, 275 insertions(+), 63 deletions(-)
create mode 100644 debian/patches/pve/0053-PVE-fix-and-clean-up-error-handling-for-create_backu.patch
--
2.20.1
next reply other threads:[~2020-10-29 13:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 13:10 Stefan Reiter [this message]
2020-10-29 13:10 ` [pve-devel] [PATCH v2 qemu 1/6] PVE: fixup: drop CoMutex on error return Stefan Reiter
2020-10-29 13:10 ` [pve-devel] [PATCH v2 qemu 2/6] PVE: Introduce generic CoCtxData struct Stefan Reiter
2020-10-29 13:10 ` [pve-devel] [PATCH v2 qemu 3/6] PVE: Don't expect complete_cb to be called outside coroutine Stefan Reiter
2020-10-29 13:10 ` [pve-devel] [PATCH v2 qemu 4/6] PVE: Don't call job_cancel in coroutines Stefan Reiter
2020-10-29 13:10 ` [pve-devel] [PATCH v2 qemu 5/6] PVE: fix and clean up error handling for create_backup_jobs Stefan Reiter
2020-10-29 13:10 ` [pve-devel] [PATCH v2 qemu 6/6] Several fixes for backup abort and error reporting Stefan Reiter
2020-10-29 17:27 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029131036.11786-1-s.reiter@proxmox.com \
--to=s.reiter@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox