From: Stefan Reiter <s.reiter@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH 0/2] QEMU backup cancellation fixes
Date: Thu, 22 Oct 2020 14:11:16 +0200 [thread overview]
Message-ID: <20201022121118.5504-1-s.reiter@proxmox.com> (raw)
Two smaller bugfixes for qmp_backup_cancel, that would lead to VM hangs or
wrongly aborted backups. Sent as seperate patches to highlight the changes, but
can probably be squashed into some of our other patches as well (lmk if I should
do that).
I also got dirty bitmap migrate working, but still needs some testing/cleanup.
I'd also like for upstream to give their final decision on the fix I sent, then
I'll confidently send that as well :)
@Dominik: If you apply these two patches, can you still reproduce the hang on
abort? I'm not sure we experienced the 'same' hang.
Stefan Reiter (2):
PVE: Don't expect complete_cb to be called outside coroutine
PVE: Don't call job_cancel in coroutines
pve-backup.c | 33 ++++++++++++++++++++++++++++-----
1 file changed, 28 insertions(+), 5 deletions(-)
--
2.20.1
next reply other threads:[~2020-10-22 12:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 12:11 Stefan Reiter [this message]
2020-10-22 12:11 ` [pve-devel] [PATCH qemu 1/2] PVE: Don't expect complete_cb to be called outside coroutine Stefan Reiter
2020-10-27 14:16 ` Wolfgang Bumiller
2020-10-27 14:57 ` Stefan Reiter
2020-10-22 12:11 ` [pve-devel] [PATCH qemu 2/2] PVE: Don't call job_cancel in coroutines Stefan Reiter
2020-10-27 14:17 ` Wolfgang Bumiller
2020-10-27 14:57 ` Stefan Reiter
2020-10-22 13:07 ` [pve-devel] [PATCH 0/2] QEMU backup cancellation fixes Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201022121118.5504-1-s.reiter@proxmox.com \
--to=s.reiter@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox