public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Oguz Bektas <o.bektas@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer] fix #3057: remove ext3 option from installer
Date: Mon,  5 Oct 2020 14:13:41 +0200	[thread overview]
Message-ID: <20201005121341.2920388-1-o.bektas@proxmox.com> (raw)

we can safely remove this from the fs options

nobody uses this anymore, and it just ends up causing problems like in
[0]

[0]: https://forum.proxmox.com/threads/emlink-too-many-links.73108/

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
 proxinstall | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/proxinstall b/proxinstall
index 4fb0748..8b0a2cb 100755
--- a/proxinstall
+++ b/proxinstall
@@ -279,7 +279,7 @@ my $config = {
 
 my $config_options = {};
 
-if ($cmdline =~ m/\s(ext3|ext4|xfs)(\s.*)?$/) {
+if ($cmdline =~ m/\s(ext4|xfs)(\s.*)?$/) {
     $config_options->{filesys} = $1;
 } else {
     $config_options->{filesys} = 'ext4';
@@ -774,12 +774,6 @@ sub update_progress {
 }
 
 my $fssetup = {
-    ext3 => {
-	mkfs => 'mkfs.ext3 -F',
-	mkfs_root_opt => '',
-	mkfs_data_opt => '-m 0',
-	root_mountopt => 'errors=remount-ro',
-    },
     ext4 => {
 	mkfs => 'mkfs.ext4 -F',
 	mkfs_root_opt => '',
@@ -2982,7 +2976,7 @@ sub create_hdoption_view {
 
     my $fstypecb = Gtk3::ComboBoxText->new();
 
-    my $fstype = ['ext3', 'ext4', 'xfs',
+    my $fstype = ['ext4', 'xfs',
 		  'zfs (RAID0)', 'zfs (RAID1)',
 		  'zfs (RAID10)', 'zfs (RAIDZ-1)',
 		  'zfs (RAIDZ-2)', 'zfs (RAIDZ-3)'];
-- 
2.20.1




             reply	other threads:[~2020-10-05 12:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-05 12:13 Oguz Bektas [this message]
2020-10-22 17:00 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201005121341.2920388-1-o.bektas@proxmox.com \
    --to=o.bektas@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal