From: Mira Limbeck <m.limbeck@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 qemu-server 1/2] fix VM clone from snapshot with cloudinit disk
Date: Mon, 28 Sep 2020 10:36:30 +0200 [thread overview]
Message-ID: <20200928083631.30407-1-m.limbeck@proxmox.com> (raw)
All volumes contained in $vollist are activated. In this case a snapshot
of the volume. For cloudinit disks no snapshots are created so don't add
it to the list of volumes to activate as it otherwise fails with no
logical volume found.
Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
---
v2: unchanged
PVE/API2/Qemu.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 8da616a..8e1bbc2 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -3000,6 +3000,7 @@ __PACKAGE__->register_method({
if !PVE::Storage::volume_has_feature($storecfg, 'clone', $drive->{file}, $snapname, $running);
}
$drives->{$opt} = $drive;
+ next if PVE::QemuServer::drive_is_cloudinit($drive);
push @$vollist, $drive->{file};
}
} else {
--
2.20.1
next reply other threads:[~2020-09-28 8:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 8:36 Mira Limbeck [this message]
2020-09-28 8:36 ` [pve-devel] [PATCH v2 qemu-server 2/2] fix clone_disk failing for nonexistent " Mira Limbeck
2020-10-05 15:35 ` Thomas Lamprecht
2020-10-06 8:56 ` Mira Limbeck
2020-10-06 11:10 ` Mira Limbeck
2020-10-16 13:45 ` Thomas Lamprecht
2020-10-16 13:40 ` [pve-devel] applied: " Thomas Lamprecht
2020-10-16 13:40 ` [pve-devel] applied: [PATCH v2 qemu-server 1/2] fix VM clone from snapshot with " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928083631.30407-1-m.limbeck@proxmox.com \
--to=m.limbeck@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox