* [pve-devel] [PATCH manager] ui: fix unchecking 'Filter VMID'
@ 2020-09-24 13:18 Dominik Csapak
2020-09-25 7:07 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2020-09-24 13:18 UTC (permalink / raw)
To: pve-devel
if the checkbox is not checked, we set the value of the vmid filter to ''
but left 'exactMatch' enabled, which means we filter all out where
the vmid is not ''
what we instead want is to remove also the exactMatch so that we
get *all* entries back not *none*
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/grid/BackupView.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/grid/BackupView.js b/www/manager6/grid/BackupView.js
index ff998315..ff8d69ec 100644
--- a/www/manager6/grid/BackupView.js
+++ b/www/manager6/grid/BackupView.js
@@ -126,6 +126,7 @@ Ext.define('PVE.grid.BackupView', {
listeners: {
change: function(cb, value) {
vmidFilter.value = !!value ? vmid : '';
+ vmidFilter.exactMatch = !!value;
updateFilter();
},
},
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread* [pve-devel] applied: [PATCH manager] ui: fix unchecking 'Filter VMID'
2020-09-24 13:18 [pve-devel] [PATCH manager] ui: fix unchecking 'Filter VMID' Dominik Csapak
@ 2020-09-25 7:07 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2020-09-25 7:07 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak
On 24.09.20 15:18, Dominik Csapak wrote:
> if the checkbox is not checked, we set the value of the vmid filter to ''
> but left 'exactMatch' enabled, which means we filter all out where
> the vmid is not ''
>
> what we instead want is to remove also the exactMatch so that we
> get *all* entries back not *none*
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/manager6/grid/BackupView.js | 1 +
> 1 file changed, 1 insertion(+)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-25 7:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-24 13:18 [pve-devel] [PATCH manager] ui: fix unchecking 'Filter VMID' Dominik Csapak
2020-09-25 7:07 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox