From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] tasks: allow API tokens to query their own UPIDs
Date: Wed, 23 Sep 2020 10:38:48 +0200 [thread overview]
Message-ID: <20200923083849.2586622-1-f.gruenbichler@proxmox.com> (raw)
and regular users to read all their own tasks as well as those of their
associated tokens.
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
PVE/API2/Tasks.pm | 20 ++++++++++++++++----
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/PVE/API2/Tasks.pm b/PVE/API2/Tasks.pm
index 5dc6a4ad..8f6ab603 100644
--- a/PVE/API2/Tasks.pm
+++ b/PVE/API2/Tasks.pm
@@ -24,6 +24,18 @@ my $convert_token_task = sub {
}
};
+my $check_task_user = sub {
+ my ($task, $user) = @_;
+
+ if ($task->{tokenid}) {
+ my $fulltoken = PVE::AccessControl::join_tokenid($task->{user}, $task->{tokenid});
+ # token only sees token tasks, user sees user + token tasks
+ return $user eq $fulltoken || $user eq $task->{user};
+ } else {
+ return $user eq $task->{user};
+ }
+};
+
__PACKAGE__->register_method({
name => 'node_tasks',
path => '',
@@ -126,7 +138,7 @@ __PACKAGE__->register_method({
my $task = shift;
return 1 if $userfilter && $task->{user} !~ m/\Q$userfilter\E/i;
- return 1 if !($auditor || $user eq $task->{user});
+ return 1 if !($auditor || $check_task_user->($task, $user));
return 1 if $typefilter && $task->{type} ne $typefilter;
@@ -253,7 +265,7 @@ __PACKAGE__->register_method({
$convert_token_task->($task);
- if ($user ne $task->{user}) {
+ if (!$check_task_user->($task, $user)) {
$rpcenv->check($user, "/nodes/$node", [ 'Sys.Modify' ]);
}
@@ -322,7 +334,7 @@ __PACKAGE__->register_method({
$convert_token_task->($task);
- if ($user ne $task->{user}) {
+ if (!$check_task_user->($task, $user)) {
$rpcenv->check($user, "/nodes/$node", [ 'Sys.Audit' ]);
}
@@ -380,7 +392,7 @@ __PACKAGE__->register_method({
$convert_token_task->($task);
- if ($user ne $task->{user}) {
+ if (!$check_task_user->($task, $user)) {
$rpcenv->check($user, "/nodes/$node", [ 'Sys.Audit' ]);
}
--
2.20.1
next reply other threads:[~2020-09-23 8:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 8:38 Fabian Grünbichler [this message]
2020-09-23 8:38 ` [pve-devel] [PATCH proxmox-widget-toolkit] tasks: include API token ID if available Fabian Grünbichler
2020-09-25 5:44 ` [pve-devel] applied: " Thomas Lamprecht
2020-09-25 5:42 ` [pve-devel] applied: [PATCH manager] tasks: allow API tokens to query their own UPIDs Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923083849.2586622-1-f.gruenbichler@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox