From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: qemu/AgentIPView: also filter out 0:0:0:0:0:0
Date: Tue, 22 Sep 2020 16:04:13 +0200 [thread overview]
Message-ID: <20200922140413.24701-1-d.csapak@proxmox.com> (raw)
it seems that some guest-agents format an non-existant mac adress
differently (e.g. macos, see [0]) so filter that also out
0: https://forum.proxmox.com/threads/macos-vm-optischer-makel.76263/
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/qemu/AgentIPView.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/www/manager6/qemu/AgentIPView.js b/www/manager6/qemu/AgentIPView.js
index fb423c98..32e8b08d 100644
--- a/www/manager6/qemu/AgentIPView.js
+++ b/www/manager6/qemu/AgentIPView.js
@@ -104,7 +104,8 @@ Ext.define('PVE.qemu.AgentIPView', {
var ips = [];
nics.forEach(function(nic) {
if (nic['hardware-address'] &&
- nic['hardware-address'] != '00:00:00:00:00:00') {
+ nic['hardware-address'] != '00:00:00:00:00:00' &&
+ nic['hardware-address'] != '0:0:0:0:0:0') {
var nic_ips = nic['ip-addresses'] || [];
nic_ips.forEach(function(ip) {
--
2.20.1
next reply other threads:[~2020-09-22 14:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 14:04 Dominik Csapak [this message]
2020-09-23 13:10 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922140413.24701-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox