public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: [pve-devel] [RFC proxmox-backup/storage/zfsonlinux] improve zpool import for freshly created zpools
Date: Wed, 16 Sep 2020 14:14:16 +0200	[thread overview]
Message-ID: <20200916121419.3997-1-s.ivanov@proxmox.com> (raw)

The issue of created zpools not being imported on boot, due to a
missing/partial/corrupt zpool.cache file is something which we see quite often
reported in our various support-channels.

With PVE the issue was mitigated (and it did not show up so often), since
pvestatd does activate all storages (which imports all referenced zpools).

This does not hold for proxmox-backup (see the thread in our community forum
[0]).

After a short off-list discussion with Fabian (G.) the following patchset
addresses the issue by adding 'zpool-import@.service' to our zfsonlinux repo
and instantiating the template unit in the API paths where we create
zpools (for storages or datastores)

quickly tested on testsetups of mine (by adding a pool and then checking
when it got imported according to the journal).


[0]: https://forum.proxmox.com/threads/pbs-chunks-error-after-update.75467/

zfsonlinux:
Stoiko Ivanov (1):
  Add systemd-unit for importing specific pools

 ...md-unit-for-importing-specific-pools.patch | 75 +++++++++++++++++++
 debian/patches/series                         |  1 +
 debian/zfsutils-linux.install                 |  1 +
 3 files changed, 77 insertions(+)
 create mode 100644 debian/patches/0008-Add-systemd-unit-for-importing-specific-pools.patch

proxmox-backup:
Stoiko Ivanov (1):
  api2/node/disks/zfs: instantiate import service

 src/api2/node/disks/zfs.rs | 5 +++++
 1 file changed, 5 insertions(+)

pve-storage:
Stoiko Ivanov (1):
  Disks: instantiate import unit for created zpool

 PVE/API2/Disks/ZFS.pm | 6 ++++++
 1 file changed, 6 insertions(+)

-- 
2.20.1





             reply	other threads:[~2020-09-16 12:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-16 12:14 Stoiko Ivanov [this message]
2020-09-16 12:14 ` [pve-devel] [RFC zfsonlinux 1/1] Add systemd-unit for importing specific pools Stoiko Ivanov
2020-09-29  3:54   ` Thomas Lamprecht
2020-09-29 13:03   ` [pve-devel] applied: " Thomas Lamprecht
2020-09-16 12:14 ` [pve-devel] [RFC proxmox-backup 1/1] api2/node/disks/zfs: instantiate import service Stoiko Ivanov
2020-09-30  7:35   ` [pve-devel] applied: [pbs-devel] " Thomas Lamprecht
2020-09-16 12:14 ` [pve-devel] [RFC storage 1/1] Disks: instantiate import unit for created zpool Stoiko Ivanov
2020-09-29 16:58   ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200916121419.3997-1-s.ivanov@proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal