[pve-devel] [PATCH container/manager 0/2] increase core limit for lxc

[pve-devel] [PATCH container/manager 0/2] increase core limit for lxc

[Oguz Bektas]

pve-container:
Oguz Bektas (1):
  fix #2938: increase limit of max cores from 128 to 512

 src/PVE/LXC/Config.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


pve-manager:
Oguz Bektas (1):
  lxc: increase limit of max cores from 128 to 512

 www/manager6/lxc/ResourceEdit.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.20.1

[pve-devel] [PATCH container 1/2] fix #2938: increase limit of max cores from 128 to 512

[Oguz Bektas]

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
 src/PVE/LXC/Config.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index 4cd669c..223b10e 100644
--- a/src/PVE/LXC/Config.pm
+++ b/src/PVE/LXC/Config.pm
@@ -401,14 +401,14 @@ my $confdesc = {
 	type => 'integer',
 	description => "The number of cores assigned to the container. A container can use all available cores by default.",
 	minimum => 1,
-	maximum => 128,
+	maximum => 512,
     },
     cpulimit => {
 	optional => 1,
 	type => 'number',
 	description => "Limit of CPU usage.\n\nNOTE: If the computer has 2 CPUs, it has a total of '2' CPU time. Value '0' indicates no CPU limit.",
 	minimum => 0,
-	maximum => 128,
+	maximum => 512,
 	default => 0,
     },
     cpuunits => {
-- 
2.20.1

[pve-devel] [PATCH manager 2/2] lxc: increase limit of max cores from 128 to 512

[Oguz Bektas]

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
 www/manager6/lxc/ResourceEdit.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/lxc/ResourceEdit.js b/www/manager6/lxc/ResourceEdit.js
index 476a9a28..0e110e60 100644
--- a/www/manager6/lxc/ResourceEdit.js
+++ b/www/manager6/lxc/ResourceEdit.js
@@ -88,7 +88,7 @@ Ext.define('PVE.lxc.CPUInputPanel', {
 		xtype: 'proxmoxintegerfield',
 		name: 'cores',
 		minValue: 1,
-		maxValue: 128,
+		maxValue: 512,
 		value: me.insideWizard ? 1 : '',
 		fieldLabel: gettext('Cores'),
 		allowBlank: true,
-- 
2.20.1

Re: [pve-devel] [PATCH container 1/2] fix #2938: increase limit of max cores from 128 to 512

[Thomas Lamprecht]

On 9/14/20 12:32 PM, Oguz Bektas wrote:
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
>  src/PVE/LXC/Config.pm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
> index 4cd669c..223b10e 100644
> --- a/src/PVE/LXC/Config.pm
> +++ b/src/PVE/LXC/Config.pm
> @@ -401,14 +401,14 @@ my $confdesc = {
>  	type => 'integer',
>  	description => "The number of cores assigned to the container. A container can use all available cores by default.",
>  	minimum => 1,
> -	maximum => 128,
> +	maximum => 512,
>      },
>      cpulimit => {
>  	optional => 1,
>  	type => 'number',
>  	description => "Limit of CPU usage.\n\nNOTE: If the computer has 2 CPUs, it has a total of '2' CPU time. Value '0' indicates no CPU limit.",
>  	minimum => 0,
> -	maximum => 128,
> +	maximum => 512,
>  	default => 0,
>      },
>      cpuunits => {
> 

why 512? please give state some actual reason for choosing such a number,
especially if it differs from our current kernel config value of 8192...

https://git.proxmox.com/?p=mirror_ubuntu-focal-kernel.git;a=blob;f=arch/x86/Kconfig;h=8ef85139553f5a4ad5187375af898266355c4177;hb=b311b46c7d1ab21bf0a11a6fa5bad76f98fb77af#l1014

Re: [pve-devel] [PATCH container 1/2] fix #2938: increase limit of max cores from 128 to 512

[Oguz Bektas]

On Tue, Sep 15, 2020 at 11:03:52AM +0200, Thomas Lamprecht wrote:
> On 9/14/20 12:32 PM, Oguz Bektas wrote:
> > Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> > ---
> >  src/PVE/LXC/Config.pm | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
> > index 4cd669c..223b10e 100644
> > --- a/src/PVE/LXC/Config.pm
> > +++ b/src/PVE/LXC/Config.pm
> > @@ -401,14 +401,14 @@ my $confdesc = {
> >  	type => 'integer',
> >  	description => "The number of cores assigned to the container. A container can use all available cores by default.",
> >  	minimum => 1,
> > -	maximum => 128,
> > +	maximum => 512,
> >      },
> >      cpulimit => {
> >  	optional => 1,
> >  	type => 'number',
> >  	description => "Limit of CPU usage.\n\nNOTE: If the computer has 2 CPUs, it has a total of '2' CPU time. Value '0' indicates no CPU limit.",
> >  	minimum => 0,
> > -	maximum => 128,
> > +	maximum => 512,
> >  	default => 0,
> >      },
> >      cpuunits => {
> > 
> 
> why 512? please give state some actual reason for choosing such a number,
> especially if it differs from our current kernel config value of 8192...
> 
> https://git.proxmox.com/?p=mirror_ubuntu-focal-kernel.git;a=blob;f=arch/x86/Kconfig;h=8ef85139553f5a4ad5187375af898266355c4177;hb=b311b46c7d1ab21bf0a11a6fa5bad76f98fb77af#l1014
it was a somewhat arbitrary value i picked, sounded big enough

but i guess you're right :)