public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v1 series 0/5] limit out and inrate of network device
Date: Fri, 11 Sep 2020 12:08:11 +0200	[thread overview]
Message-ID: <20200911100816.80543-1-h.laimer@proxmox.com> (raw)

'rate' is split into 'outrate' and 'inrate', so the upload and download
limit can be set individually. Old configs containing just 'rate' are
mapped to out/inrate. After opening the edit dialog in the gui 'rate'
will be removed from the config and out/inrate are added. In the WebUI
the field Rate is also replace with the two new fields.
Since we can only set rules for the tap-device in the host system, we
are only able to limit the downloadrate of the VM accuratelly(egress of
tap). Setting an uploadrate limit is neither precise nor consistent due
to the nature of ingress traffic shaping(ingress of tap/outrate of VM)

pve-common: Hannes Laimer (2):
  replace rate with out/in-rate in setup_tc_rate_limit and
    tap_rate_limit
  add out/in-rate parameter to tap_plug sub, keep version with just rate
    param

 src/PVE/Network.pm | 43 +++++++++++++++++++++++++++----------------
 1 file changed, 27 insertions(+), 16 deletions(-)


pve-network: Hannes Laimer (1):
  add out/in-rate parameter to tap_plug sub, keep version with just rate
    param

 PVE/Network/SDN/Zones.pm | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)


qemu-server: Hannes Laimer (1):
  add fields inrate and outrate to net_fmt, map rate of old configs to
    out/inrate

 PVE/QemuServer.pm             | 35 +++++++++++++++++++++++++++++------
 vm-network-scripts/pve-bridge |  9 ++++++---
 2 files changed, 35 insertions(+), 9 deletions(-)


pve-manager: Hannes Laimer (1):
  out/in-rate in network edit, keep rate to still be able to open old
    configs

 www/manager6/Parser.js           | 18 ++++++++++++++++++
 www/manager6/qemu/NetworkEdit.js | 27 ++++++++++++++++++++++++---
 2 files changed, 42 insertions(+), 3 deletions(-)

-- 
2.20.1





             reply	other threads:[~2020-09-11 10:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-11 10:08 Hannes Laimer [this message]
2020-09-11 10:08 ` [pve-devel] [PATCH v1 pve-common 1/5] replace rate with out/in-rate in setup_tc_rate_limit and tap_rate_limit Hannes Laimer
2021-02-06 14:29   ` Thomas Lamprecht
2020-09-11 10:08 ` [pve-devel] [PATCH v1 pve-common 2/5] add out/in-rate parameter to tap_plug sub, keep version with just rate param Hannes Laimer
2021-02-06 14:22   ` Thomas Lamprecht
2021-04-29 14:57   ` Thomas Lamprecht
2020-09-11 10:08 ` [pve-devel] [PATCH v1 pve-network 3/5] " Hannes Laimer
2020-09-11 10:08 ` [pve-devel] [PATCH v1 qemu-server 4/5] add fields inrate and outrate to net_fmt, map rate of old configs to out/inrate Hannes Laimer
2020-09-11 10:08 ` [pve-devel] [PATCH v1 pve-manager 5/5] out/in-rate in network edit, keep rate to still be able to open old configs Hannes Laimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200911100816.80543-1-h.laimer@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal