public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH RFC manager 1/2] ui: adapt/optimize calendar event examples
Date: Thu, 10 Sep 2020 14:57:08 +0200	[thread overview]
Message-ID: <20200910125711.28369-3-d.csapak@proxmox.com> (raw)
In-Reply-To: <20200910125711.28369-1-d.csapak@proxmox.com>

pbs cannot parse minutes alone
(if the hours would be optional it would be ambiguies between hh:mm and mm:ss)

so we adapt the examples here, so that newly created schedules from the
examples include always the hour

also replace */x with 0/x. they are semantically the same, but the
latter is also valid in systemd, while the former is not

also reduce the */1 to * since the /1 does not do anything

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/form/CalendarEvent.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/www/manager6/form/CalendarEvent.js b/www/manager6/form/CalendarEvent.js
index c3b9ecab..1cb8d492 100644
--- a/www/manager6/form/CalendarEvent.js
+++ b/www/manager6/form/CalendarEvent.js
@@ -11,11 +11,11 @@ Ext.define('PVE.form.CalendarEvent', {
     store: {
 	field: [ 'value', 'text'],
 	data: [
-	    { value: '*/30', text: Ext.String.format(gettext("Every {0} minutes"), 30) },
-	    { value: '*/2:00', text: gettext("Every two hours")},
+	    { value: '*:00/30', text: Ext.String.format(gettext("Every {0} minutes"), 30) },
+	    { value: '00/2:00', text: gettext("Every two hours")},
 	    { value: '2,22:30', text: gettext("Every day") + " 02:30, 22:30"},
 	    { value: 'mon..fri', text: gettext("Monday to Friday") + " 00:00"},
-	    { value: 'mon..fri */1:00', text: gettext("Monday to Friday") + ': ' +  gettext("hourly")},
+	    { value: 'mon..fri *:00', text: gettext("Monday to Friday") + ': ' +  gettext("hourly")},
 	    { value: 'sun 01:00', text: gettext("Sunday") + " 01:00"}
 	]
     },
-- 
2.20.1





  parent reply	other threads:[~2020-09-10 12:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10 12:57 [pve-devel] [PATCH RFC guest-common/manager/docs] adapt calendar events to pbs/systemd style Dominik Csapak
2020-09-10 12:57 ` [pve-devel] [PATCH RFC guest-common 1/1] ReplicationConfig: transform schedules to include always hours Dominik Csapak
2020-09-10 12:57 ` Dominik Csapak [this message]
2020-09-10 12:57 ` [pve-devel] [PATCH RFC manager 2/2] ui: grid/Replication: change the default format of schedule text Dominik Csapak
2020-09-10 12:57 ` [pve-devel] [PATCH docs 1/2] pvesr: fix calendar event examples Dominik Csapak
2020-09-10 12:57 ` [pve-devel] [PATCH RFC docs 2/2] pvesr: modify examples to fit with pbs style Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200910125711.28369-3-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal