public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH RFC guest-common/manager/docs] adapt calendar events to pbs/systemd style
Date: Thu, 10 Sep 2020 14:57:06 +0200	[thread overview]
Message-ID: <20200910125711.28369-1-d.csapak@proxmox.com> (raw)

pbs cannot handle minute only calendar events
(because we support seconds there and hh:mm and mm:ss would be ambiguous)

so we want to eventually remove that in pve (in a future major version)
to have a consistent calendarevent syntax

for this we do 4 things here:

* transform such events when writing the replication config (to *:YYY)
* adapt the defaults in the gui (to include the hour as *)
* rewrite the docs to not mention that the hour is optional
* replace */x with 0/x since that works in systemd too

the parser still is the same, so existing config stay valid
and on the next config write, the syntax will automatically adapt
(this way we can have a parse/write cycle e.g. in an pve6to7 script
and can be sure we have the new syntax)

pve-guest-common:

Dominik Csapak (1):
  ReplicationConfig: transform schedules to include always hours

 PVE/ReplicationConfig.pm | 31 ++++++++++++++++++++++++++++++-
 1 file changed, 30 insertions(+), 1 deletion(-)

pve-manager:

Dominik Csapak (2):
  ui: adapt/optimize calendar event examples
  ui: grid/Replication: change the default format of schedule text

 www/manager6/form/CalendarEvent.js | 6 +++---
 www/manager6/grid/Replication.js   | 7 ++++---
 2 files changed, 7 insertions(+), 6 deletions(-)

pve-docs:

Dominik Csapak (2):
  pvesr: fix calendar event examples
  pvesr: modify examples to fit with pbs style

 pvesr.adoc | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

-- 
2.20.1





             reply	other threads:[~2020-09-10 12:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10 12:57 Dominik Csapak [this message]
2020-09-10 12:57 ` [pve-devel] [PATCH RFC guest-common 1/1] ReplicationConfig: transform schedules to include always hours Dominik Csapak
2020-09-10 12:57 ` [pve-devel] [PATCH RFC manager 1/2] ui: adapt/optimize calendar event examples Dominik Csapak
2020-09-10 12:57 ` [pve-devel] [PATCH RFC manager 2/2] ui: grid/Replication: change the default format of schedule text Dominik Csapak
2020-09-10 12:57 ` [pve-devel] [PATCH docs 1/2] pvesr: fix calendar event examples Dominik Csapak
2020-09-10 12:57 ` [pve-devel] [PATCH RFC docs 2/2] pvesr: modify examples to fit with pbs style Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200910125711.28369-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal