public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: dc/Backup: disable pveCompressionSelector for pbs storages
Date: Thu,  3 Sep 2020 14:08:14 +0200	[thread overview]
Message-ID: <20200903120814.23862-1-d.csapak@proxmox.com> (raw)

like in window/Backup

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
i'd really like to incorporate that info into our storage plugin api
so that we do not have to hardcode 'pbs', but for it's okay i guess

 www/manager6/dc/Backup.js | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index e9f20596..d868dcfc 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -61,7 +61,21 @@ Ext.define('PVE.dc.BackupEdit', {
 	    nodename: 'localhost',
 	    storageContent: 'backup',
 	    allowBlank: false,
-	    name: 'storage'
+	    name: 'storage',
+	    listeners: {
+		change: function(f, v) {
+		    let store = f.getStore();
+		    let rec = store.findRecord('storage', v);
+		    let compressionSelector = me.down('pveCompressionSelector');
+
+		    if (rec && rec.data && rec.data.type === 'pbs') {
+			compressionSelector.setValue('zstd');
+			compressionSelector.setDisabled(true);
+		    } else if (!compressionSelector.getEditable()) {
+			compressionSelector.setDisabled(false);
+		    }
+		}
+	    }
 	});
 
 	var store = new Ext.data.Store({
-- 
2.20.1





             reply	other threads:[~2020-09-03 12:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-03 12:08 Dominik Csapak [this message]
2020-09-03 16:04 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200903120814.23862-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal